Follow up renaming of ML modules#10723
Merged
kvch merged 3 commits intoelastic:masterfrom Feb 13, 2019
Merged
Conversation
ruflin
approved these changes
Feb 13, 2019
Contributor
|
++ on having a more reliable solution long term. |
ph
approved these changes
Feb 13, 2019
Contributor
Author
|
All related tests are green in Travis, Jenkins is completely green, so merging. |
kvch
added a commit
to kvch/beats
that referenced
this pull request
Feb 13, 2019
Two renamings has happened which lead to the problem: * the Filebeat module apache2 has been renamed to apache * the ID of ML modules has been suffixed with _ecs As it is still a fragile solution, I have opened an issue for the ML team to add the possibility of listing all available modules with additional meta data: elastic/kibana#30934 (cherry picked from commit 7542db1)
kvch
added a commit
to kvch/beats
that referenced
this pull request
Feb 13, 2019
Two renamings has happened which lead to the problem: * the Filebeat module apache2 has been renamed to apache * the ID of ML modules has been suffixed with _ecs As it is still a fragile solution, I have opened an issue for the ML team to add the possibility of listing all available modules with additional meta data: elastic/kibana#30934 (cherry picked from commit 7542db1)
kvch
added a commit
that referenced
this pull request
Feb 14, 2019
Two renamings has happened which lead to the problem: * the Filebeat module apache2 has been renamed to apache * the ID of ML modules has been suffixed with _ecs As it is still a fragile solution, I have opened an issue for the ML team to add the possibility of listing all available modules with additional meta data: elastic/kibana#30934 (cherry picked from commit 7542db1)
kvch
added a commit
that referenced
this pull request
Feb 14, 2019
Two renamings has happened which lead to the problem: * the Filebeat module apache2 has been renamed to apache * the ID of ML modules has been suffixed with _ecs As it is still a fragile solution, I have opened an issue for the ML team to add the possibility of listing all available modules with additional meta data: elastic/kibana#30934 (cherry picked from commit 7542db1)
Contributor
As an alternative and/or complementary option to listing available ML modules, would it also be useful to check the return from the call to setup the ML module? |
Contributor
Author
|
I am sorry, I am not sure I follow. Do you mean that we could try to setup ML for every Filebeat module to see which ones are available? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two renamings has happened which lead to the problem:
_ecsAs it is still a fragile solution, I have opened an issue for the ML team to add the possibility of listing all available modules with additional meta data: elastic/kibana#30934