Skip to content

Revert changes in timezones in filebeat expected results#10663

Merged
jsoriano merged 2 commits intoelastic:masterfrom
jsoriano:revert-tz-changes
Feb 11, 2019
Merged

Revert changes in timezones in filebeat expected results#10663
jsoriano merged 2 commits intoelastic:masterfrom
jsoriano:revert-tz-changes

Conversation

@jsoriano
Copy link
Copy Markdown
Member

There was a regression in ES snapshots when parsing timezones and we
adapted the expected results to the incorrect values in #10441. Revert
these changes when the fixed ES images are ready.

There was a regression in ES when parsing timezones and we adapted the
expected results to the incorrect values in elastic#10441. Revert these changes
when the fixed ES images are ready.
@jsoriano jsoriano added module Filebeat Filebeat :Testing Team:Integrations Label for the Integrations team labels Feb 11, 2019
@jsoriano jsoriano self-assigned this Feb 11, 2019
@jsoriano jsoriano requested a review from a team as a code owner February 11, 2019 10:05
Copy link
Copy Markdown
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as soon as we have the build ready ;-)

@ruflin ruflin added the needs_backport PR is waiting to be backported to other branches. label Feb 11, 2019
@ruflin
Copy link
Copy Markdown
Contributor

ruflin commented Feb 11, 2019

@jsoriano Added needs_backport to also have this in 7.0

@ruflin ruflin self-assigned this Feb 11, 2019
@jsoriano jsoriano merged commit f9be490 into elastic:master Feb 11, 2019
@jsoriano jsoriano deleted the revert-tz-changes branch February 11, 2019 17:55
jsoriano added a commit to jsoriano/beats that referenced this pull request Feb 11, 2019
There was a regression in ES when parsing timezones and we adapted the
expected results to the incorrect values in elastic#10441. Revert these changes
when the fixed ES images are ready.

(cherry picked from commit f9be490)
@jsoriano jsoriano added v7.0.0 and removed needs_backport PR is waiting to be backported to other branches. labels Feb 11, 2019
@ycombinator
Copy link
Copy Markdown
Contributor

ycombinator commented Feb 11, 2019

@jsoriano should this PR be backported to the 7.x branch as well?

[EDIT] I setup the backport PR here: #10685

jsoriano added a commit that referenced this pull request Feb 11, 2019
…0678)

There was a regression in ES when parsing timezones and we adapted the
expected results to the incorrect values in #10441. Revert these changes
when the fixed ES images are ready.

(cherry picked from commit f9be490)
@jsoriano
Copy link
Copy Markdown
Member Author

@ycombinator I think the plan for 7.x is to do mass backports from master by now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants