Skip to content

[Auditbeat] System module dashboards#10511

Merged
cwurm merged 14 commits intoelastic:masterfrom
cwurm:auditbeat_system_overview_dashboard
Feb 5, 2019
Merged

[Auditbeat] System module dashboards#10511
cwurm merged 14 commits intoelastic:masterfrom
cwurm:auditbeat_system_overview_dashboard

Conversation

@cwurm
Copy link
Copy Markdown
Contributor

@cwurm cwurm commented Feb 3, 2019 •
edited
Loading

7 dashboards for the System module - one for each dataset, and an overall overview dashboards.

1/7 System Overview Dashboard

auditbeat-system-overview-dashboard

2/7 Host Dashboard

auditbeat-system-host-dashboard

3/7 Login Dashboard

auditbeat-system-login-dashboard

4/7 User Dashboard

auditbeat-system-user-dashboard

5/7 Process Dashboard

auditbeat-system-process-dashboard

6/7 Socket Dashboard

auditbeat-system-socket-dashboard

7/7 Package Dashboard

auditbeat-system-package-dashboard

Depends on #10500 for {entity}.entity_id fields.

Supersedes #10160 (Host Dashboard).

@cwurm cwurm added review needs_backport PR is waiting to be backported to other branches. Auditbeat SecOps labels Feb 3, 2019
@cwurm cwurm requested review from a team as code owners February 3, 2019 23:24
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 3, 2019

Pinging @elastic/secops

@cwurm cwurm mentioned this pull request Feb 3, 2019
Closed
@cwurm
Copy link
Copy Markdown
Contributor Author

cwurm commented Feb 3, 2019

I forgot to mention this dashboard depends on the {entity}.entity_id fields proposed in #10500 and this PR is therefore blocked for now.

tsg
tsg reviewed Feb 4, 2019
View reviewed changes
script/build_docs.sh Outdated
Copy link
Copy Markdown
Contributor

@tsg tsg Feb 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the double -open needed here? I would say not, but not sure.

Copy link
Copy Markdown
Contributor Author

@cwurm cwurm Feb 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work without it as well. And the chunk=1 also seems superfluous since right above it already sets --chunk=1. It works without both of them for me, so I'm removing both.

tsg
tsg approved these changes Feb 4, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@tsg tsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the dashboard :)

@cwurm cwurm changed the title [Auditbeat] System Overview dashboard [Auditbeat] System module dashboards Feb 4, 2019
@cwurm
Copy link
Copy Markdown
Contributor Author

cwurm commented Feb 4, 2019

Updated PR description to reflect there are now 7 dashboards after all.

webmat
webmat approved these changes Feb 5, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwurm cwurm force-pushed the auditbeat_system_overview_dashboard branch from ed5e418 to 6068113 Compare February 5, 2019 14:12
@cwurm cwurm merged commit 38d5f43 into elastic:master Feb 5, 2019
@cwurm cwurm deleted the auditbeat_system_overview_dashboard branch February 5, 2019 16:21
@cwurm cwurm mentioned this pull request Feb 5, 2019
Merged
@cwurm cwurm removed the needs_backport PR is waiting to be backported to other branches. label Feb 5, 2019
cwurm pushed a commit to cwurm/beats that referenced this pull request Feb 5, 2019
[Auditbeat] System module dashboards (elastic#10511)
a48eb89 
Seven dashboards for the Auditbeat System module - one for each dataset, and an overall overview dashboards.

(cherry picked from commit 38d5f43)
@cwurm cwurm added the v6.7.0 label Feb 5, 2019
cwurm pushed a commit that referenced this pull request Feb 5, 2019
[Auditbeat] Changelog for #10511
dd29a63
cwurm pushed a commit that referenced this pull request Feb 5, 2019
[Auditbeat] Cherry-pick #10511 to 6.x: System module dashboards (#10574)
3f5b1ab 
Cherry-pick of PR #10511 to 6.x branch. Original message: 

Seven dashboards for the Auditbeat System module - one for each dataset, and an overall overview dashboards.

(cherry picked from commit 38d5f43)
@cwurm cwurm mentioned this pull request Feb 9, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@webmat webmat webmat approved these changes

@tsg tsg tsg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Auditbeat review v6.7.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cwurm @elasticmachine @webmat @tsg