[Auditbeat] Read formula path from INSTALL_RECEIPT.json for Homebrew packages#10507
Merged
cwurm merged 3 commits intoelastic:masterfrom Feb 5, 2019
Merged
Conversation
Contributor
|
Pinging @elastic/secops |
Contributor
Author
|
jenkins, test this |
added 2 commits
February 4, 2019 16:55
8e5dab0 to
fb25834
Compare
andrewkroh
requested changes
Feb 4, 2019
andrewkroh
approved these changes
Feb 5, 2019
cwurm
pushed a commit
to cwurm/beats
that referenced
this pull request
Feb 5, 2019
…packages (elastic#10507) When reading Homebrew packages, changes to reading the path to the Ruby formula from `/usr/local/Cellar/{pkg.Name}/{pkg.Version}/INSTALL_RECEIPT.json` and fall back to the previous `/usr/local/Cellar/{pkg.Name}/{pkg.Version}/.brew/{pkg.Name}.rb` only if that does not work. (cherry picked from commit 912ef57)
cwurm
pushed a commit
that referenced
this pull request
Feb 5, 2019
…packages (#10507) (#10559) When reading Homebrew packages, changes to reading the path to the Ruby formula from `/usr/local/Cellar/{pkg.Name}/{pkg.Version}/INSTALL_RECEIPT.json` and fall back to the previous `/usr/local/Cellar/{pkg.Name}/{pkg.Version}/.brew/{pkg.Name}.rb` only if that does not work. (cherry picked from commit 912ef57)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reading Homebrew packages, changes to reading the path to the Ruby formula from
/usr/local/Cellar/{pkg.Name}/{pkg.Version}/INSTALL_RECEIPT.jsonand fall back to the previous/usr/local/Cellar/{pkg.Name}/{pkg.Version}/.brew/{pkg.Name}.rbonly if that does not work.On my Mac this read the whole 99 packages and their versions (confirmed with
find /usr/local/Cellar -type d -depth 2 | wc -l), where the previous logic read only 92.