Remove accidental overwrite of user_agent.device.name by user_agent.device#10472
Merged
webmat merged 4 commits intoelastic:masterfrom Feb 1, 2019
Merged
Remove accidental overwrite of user_agent.device.name by user_agent.device#10472webmat merged 4 commits intoelastic:masterfrom
webmat merged 4 commits intoelastic:masterfrom
Conversation
webmat
commented
Jan 31, 2019
libbeat/_meta/fields.ecs.yml
Outdated
Contributor
Author
There was a problem hiding this comment.
This field def overrides the real ECS field, defined on line 2180
801c01e to
c5f03c5
Compare
5 tasks
ruflin
approved these changes
Feb 1, 2019
Contributor
ruflin
left a comment
There was a problem hiding this comment.
Good to be merged, CI failure is not related.
libbeat/_meta/fields.ecs.yml
Outdated
48e4ed4 to
f7b6f07
Compare
Contributor
Author
|
jenkins, test this |
Contributor
Author
|
Yep, test failures still unrelated after rebase. Merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cleanup that can and should go in before #10441.