Move Metricbeat module fields to ECS#10218
Closed
ruflin wants to merge 37 commits intoelastic:masterfrom
Closed
Conversation
Contributor
Author
|
@webmat @andrewkroh Feedback would be appreciated. |
webmat
reviewed
Jan 21, 2019
Contributor
webmat
left a comment
There was a problem hiding this comment.
Ok, I'm only partway done. It's a big one LOL
I will pick up at Kibana next time around
webmat
reviewed
Jan 22, 2019
webmat
reviewed
Jan 22, 2019
Contributor
webmat
left a comment
There was a problem hiding this comment.
Ok, tried to cover everything. Some of the messages are short and to the point LOL.
Contributor
Author
|
@ycombinator Could you check the discussions in this PR which are for the Elastic Stack modules and if you agree, open PR(s) for the changes? |
ycombinator
reviewed
Jan 23, 2019
ycombinator
reviewed
Jan 23, 2019
As part of the migration to ECS and some cleanup I went through the metricbeat modules to see if there are also fields which should be migrated to ECS. As there are just too many fields to check I focused on the following 3 types: keyword, ip, contains network or host in the name. So far I only added some notes to the fields.yml for discussion. When we agree what should happen we can apply to to all the modules/metricsets.
Contributor
Author
|
@webmat For now I suggest we skip all changes related to |
ycombinator
reviewed
Jan 26, 2019
metricbeat/module/elasticsearch/index_recovery/_meta/fields.yml
Outdated
Show resolved
Hide resolved
ruflin
commented
Jan 28, 2019
webmat
reviewed
Jan 28, 2019
ycombinator
added a commit
that referenced
this pull request
Jan 31, 2019
This PR updates a few fields in the Elastic stack modules in Metricbeat, viz. `elasticsearch`, `logstash`, and `kibana` to their ECS names and types. Based on discussions happening in #10218, but only scoped to Elastic stack modules.
ruflin
commented
Jan 31, 2019
ruflin
commented
Feb 5, 2019
Contributor
Author
ruflin
left a comment
There was a problem hiding this comment.
Closing this PR as everything we wanted to address has follow up PR's.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of the migration to ECS and some cleanup I went through the metricbeat modules to see if there are also fields which should be migrated to ECS. As there are just too many fields to check I focused on the following 3 types: keyword, ip, contains network or host in the name.
So far I only added some notes to the fields.yml for discussion. When we agree what should happen we can apply to to all the modules/metricsets.
The idea is to apply the changes in other PR's and have this only for discussions.
If there are more fields that need migration, please comment with them here.