Elasticsearch/audit fileset should be more lenient in parsing node name#10135
Merged
ycombinator merged 4 commits intoelastic:masterfrom Jan 18, 2019
ycombinator:fb-es-audit-bugfix
Merged
Elasticsearch/audit fileset should be more lenient in parsing node name#10135ycombinator merged 4 commits intoelastic:masterfrom ycombinator:fb-es-audit-bugfix
ycombinator merged 4 commits intoelastic:masterfrom
ycombinator:fb-es-audit-bugfix
Conversation
Contributor
|
Pinging @elastic/stack-monitoring |
Contributor
Author
|
jenkins, test this |
ruflin
reviewed
Jan 17, 2019
Contributor
There was a problem hiding this comment.
@webmat just pinging you here on this for awareness. looks like ECS data.
Contributor
There was a problem hiding this comment.
Yes, let's look at event categorization after FF. This field is fine 👍
ruflin
approved these changes
Jan 17, 2019
webmat
reviewed
Jan 18, 2019
| "ES_AUDIT_REQUEST_BODY": "(request_body\\=\\[%{DATA:http.request.body.content}\\])?" | ||
| }, | ||
| "patterns": [ | ||
| "%{ES_TIMESTAMP}\\s*%{ES_NODE_NAME}\\s*%{ES_AUDIT_LAYER}\\s*%{ES_AUDIT_EVENT_TYPE}\\s*%{ES_AUDIT_ORIGIN_TYPE},?\\s*%{ES_AUDIT_ORIGIN_ADDRESS},?\\s*%{ES_AUDIT_PRINCIPAL},?\\s*%{ES_AUDIT_ACTION},?\\s*%{ES_AUDIT_URI},?\\s*%{ES_AUDIT_REQUEST},?\\s*%{ES_AUDIT_REQUEST_BODY},?" |
webmat
approved these changes
Jan 18, 2019
Contributor
webmat
left a comment
There was a problem hiding this comment.
Love the improved readability 💯
ycombinator
added a commit
that referenced
this pull request
Jan 21, 2019
… lenient in parsing node name (#10174) Cherry-pick of PR #10135 to 6.x branch. Original message: Resolves #10035. This PR: * Uses `DATA` instead of `WORD` in the grok pattern for parsing out `elasticsearch.node.name`, * Breaks out the grok pattern into pattern definitions to increase readability * Removes a redundant `?` after a `*` in the grok pattern (between `elasticsearch.audit.action` and `elasticsearch.audit.uri`), and * Properly reindents the pipeline JSON (so you might want to view the diff with `?w=1` appended to the URL)
ycombinator
added a commit
that referenced
this pull request
Feb 1, 2019
… lenient in parsing node name (#10465) Cherry-pick of PR #10135 to 6.6 branch. Original message: Resolves #10035. This PR: * Uses `DATA` instead of `WORD` in the grok pattern for parsing out `elasticsearch.node.name`, * Breaks out the grok pattern into pattern definitions to increase readability * Removes a redundant `?` after a `*` in the grok pattern (between `elasticsearch.audit.action` and `elasticsearch.audit.uri`), and * Properly reindents the pipeline JSON (so you might want to view the diff with `?w=1` appended to the URL)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…be more lenient in parsing node name (elastic#10465) Cherry-pick of PR elastic#10135 to 6.6 branch. Original message: Resolves elastic#10035. This PR: * Uses `DATA` instead of `WORD` in the grok pattern for parsing out `elasticsearch.node.name`, * Breaks out the grok pattern into pattern definitions to increase readability * Removes a redundant `?` after a `*` in the grok pattern (between `elasticsearch.audit.action` and `elasticsearch.audit.uri`), and * Properly reindents the pipeline JSON (so you might want to view the diff with `?w=1` appended to the URL)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #10035.
This PR:
DATAinstead ofWORDin the grok pattern for parsing outelasticsearch.node.name,?after a*in the grok pattern (betweenelasticsearch.audit.actionandelasticsearch.audit.uri), and?w=1appended to the URL)