Skip to content

Backport to 6.x: Handle IPv6 zone id in IIS filebeat ingest pipeline for access logs too#10029

Merged
webmat merged 2 commits intoelastic:6.xfrom
webmat:backport-iis-access-ipv6zone-fix-6.x
Jan 14, 2019
Merged

Backport to 6.x: Handle IPv6 zone id in IIS filebeat ingest pipeline for access logs too#10029
webmat merged 2 commits intoelastic:6.xfrom
webmat:backport-iis-access-ipv6zone-fix-6.x

Conversation

@webmat
Copy link
Copy Markdown
Contributor

@webmat webmat commented Jan 11, 2019

This is a manual backport, to fix an issue with the iis module, with regards to IP literals containing an IPv6 zone ID (issue #9836). This was fixed in master as part of the ECS conversion of the iis module (#9955).

Contrary to the fix in master, this fix is in line with Jaime's fix for the IIS error logs (#9869, #9932, #9933). This means the IP literal is saved as is to iis.access.remote_ip (including the zone). This is fine, because this is a keyword field. The GeoIP processor then uses an IP literal with the zone stripped out, to avoid hitting the error. Note that this cleaned up field is not kept around in the 6.x line.

@webmat webmat self-assigned this Jan 11, 2019
@webmat
Copy link
Copy Markdown
Contributor Author

webmat commented Jan 11, 2019

jenkins, test this

@webmat
Copy link
Copy Markdown
Contributor Author

webmat commented Jan 11, 2019

@jsoriano Any reason why you didn't backport your IPv6 zone fix to 6.5? Original reporter was on 6.5.

I'm not used to doing backports. Not sure what our policy is, on what goes into which past version.

@jsoriano
Copy link
Copy Markdown
Member

@jsoriano Any reason why you didn't backport your IPv6 zone fix to 6.5? Original reporter was on 6.5.

I'm not used to doing backports. Not sure what our policy is, on what goes into which past version.

No reason, I was just not so sure of considering this just a fix/workaround or an enhancement. I am also not so happy with this workaround, I wouldn't like to have to add this to all pipelines that can have IPv6 addresses.
I'd be happy to backport it to 6.5 too, wdyt?

@webmat webmat merged commit 75375aa into elastic:6.x Jan 14, 2019
webmat added a commit that referenced this pull request Jan 14, 2019
@webmat webmat deleted the backport-iis-access-ipv6zone-fix-6.x branch January 14, 2019 13:50
@webmat
Copy link
Copy Markdown
Contributor Author

webmat commented Jan 14, 2019

@jsoriano Agreed, I don't want us to have to do this cleanup everywhere. Hopefully Elasticsearch adds support for the Zone ID in the geoip plugin and in the ip datatype. You did open an issue about this, right?

Let's backport to 6.5, yes. Are you saying you're willing to backport both fixes? ;-)

@jsoriano
Copy link
Copy Markdown
Member

@webmat yes, I opened an issue, it seems that this will be implemented for the geoip plugin, but not in the general implementation in Elasticsearch (elastic/elasticsearch#37107)

And ok, I backport these fixes 🙂

jsoriano pushed a commit to jsoriano/beats that referenced this pull request Jan 14, 2019
… ingest pipeline for access logs too (elastic#10030)

(cherry picked from commit e05f967)
@webmat
Copy link
Copy Markdown
Contributor Author

webmat commented Jan 14, 2019

@jsoriano Perfect, thank you! Make sure to ping me on the 6.5 PR :-)

leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants