Fix TCP & UDP input metricsets for ports > 32767 (#46486)

belimawr · web-flow · commit 8ee768567d41 · 2025-09-10T14:43:36.000-04:00
When parsing the port to collect metrics, the TCP &amp; UDP inputs were
parsing the port as a int16, which limited the maximum port to
32767. This commit fixes it by parsing the port as uint16.
diff --git a/CHANGELOG.next.asciidoc b/CHANGELOG.next.asciidoc
@@ -280,6 +280,7 @@ otherwise no tag is added. {issue}42208[42208] {pull}42403[42403]
 - The Unix input now fails on errors listening to the socket and its status is set to failed when running under Elastic Agent. {pull}46302[46302]
 - Fix race condition that could cause Filebeat to hang during shutdown after failing to startup {issue}45034[45034] {pull}46331[46331]
 - Fixed hints autodiscover for Docker when the configuration is only `hints.enabled: true`. {issue}45156[45156] {pull}45864[45864]
+- Fix metrics from TCP & UDP inputs when the port number is > 32767 {pull}46486[46486]
 
 *Heartbeat*
 
diff --git a/filebeat/input/netmetrics/netmetrics.go b/filebeat/input/netmetrics/netmetrics.go
@@ -48,7 +48,7 @@ func addrs(addr string, log *logp.Logger) (addr4, addr6 []string, err error) {
 	if err != nil {
 		return nil, nil, fmt.Errorf("failed to get address for %s: %w", addr, err)
 	}
-	pn, err := strconv.ParseInt(port, 10, 16)
+	pn, err := strconv.ParseUint(port, 10, 16)
 	if err != nil {
 		return nil, nil, fmt.Errorf("failed to get port for %s: %w", addr, err)
 	}
diff --git a/filebeat/input/netmetrics/netmetrics_test.go b/filebeat/input/netmetrics/netmetrics_test.go
@@ -30,7 +30,7 @@ import (
 
 func TestAddrs(t *testing.T) {
 	t.Run("ipv4", func(t *testing.T) {
-		addr4, addr6, err := addrs("0.0.0.0:9001", logptest.NewTestingLogger(t, ""))
+		addr4, addr6, err := addrs("0.0.0.0:65535", logptest.NewTestingLogger(t, ""))
 		if err != nil {
 			t.Errorf("unexpected error: %v", err)
 		}

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ func addrs(addr string, log *logp.Logger) (addr4, addr6 []string, err error) {`
`48`	`48`	`if err != nil {`
`49`	`49`	`return nil, nil, fmt.Errorf("failed to get address for %s: %w", addr, err)`
`50`	`50`	`}`
`51`		`- pn, err := strconv.ParseInt(port, 10, 16)`
	`51`	`+ pn, err := strconv.ParseUint(port, 10, 16)`
`52`	`52`	`if err != nil {`
`53`	`53`	`return nil, nil, fmt.Errorf("failed to get port for %s: %w", addr, err)`
`54`	`54`	`}`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ import (`
`30`	`30`
`31`	`31`	`func TestAddrs(t *testing.T) {`
`32`	`32`	`t.Run("ipv4", func(t *testing.T) {`
`33`		`- addr4, addr6, err := addrs("0.0.0.0:9001", logptest.NewTestingLogger(t, ""))`
	`33`	`+ addr4, addr6, err := addrs("0.0.0.0:65535", logptest.NewTestingLogger(t, ""))`
`34`	`34`	`if err != nil {`
`35`	`35`	`t.Errorf("unexpected error: %v", err)`
`36`	`36`	`}`