Skip to content

support output.elasticsearch.max_requests#8055

Merged
stuartnelson3 merged 4 commits intoelastic:mainfrom
stuartnelson3:configurable-max-requests
May 6, 2022
Merged

support output.elasticsearch.max_requests#8055
stuartnelson3 merged 4 commits intoelastic:mainfrom
stuartnelson3:configurable-max-requests

Conversation

@stuartnelson3
Copy link
Copy Markdown
Contributor

@stuartnelson3 stuartnelson3 commented May 5, 2022 •
edited
Loading

Motivation/summary

make the number of bulk requests in the
modelindexer configurable via
output.elasticsearch.max_requests

Checklist

How to test these changes

Configure output.elasticsearch.max_requests and set http.enabled=true. Start the apm-server, curl the stats endpoint, and confirm that the number of available bulk requests matches the amount configured:

# curl -s localhost:5066/stats | jq '.output.elasticsearch.bulk_requests'
{
  "available": 25,
  "completed": 0
}

Related issues

closes #7719

@stuartnelson3
support output.elasticsearch.max_requests
ed2c3b6 
make the number of bulk requests in the
modelindexer configurable via
`output.elasticsearch.max_requests`
@stuartnelson3 stuartnelson3 added this to the 8.3 milestone May 5, 2022
@stuartnelson3 stuartnelson3 requested a review from a team May 5, 2022 12:15
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented May 5, 2022

This pull request does not have a backport label. Could you fix it @stuartnelson3? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.x is the label to automatically backport to the 7.x branch.
  • backport-7./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label May 5, 2022
@stuartnelson3 stuartnelson3 added backport-8.3 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels May 5, 2022
@stuartnelson3
Copy link
Copy Markdown
Contributor Author

stuartnelson3 commented May 5, 2022

Are we going to make this configurable in the integration package?

@ghost
Copy link
Copy Markdown

ghost commented May 5, 2022 •
edited by ghost
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-06T07:40:53.455+0000

  • Duration: 26 min 42 sec

Test stats 🧪

Test Results
Failed 0
Passed 3981
Skipped 13
Total 3994

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /hey-apm : Run the hey-apm benchmark.

  • /package : Generate and publish the docker images.

  • /test windows : Build & tests on Windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@ghost
Copy link
Copy Markdown

ghost commented May 5, 2022 •
edited by ghost
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (43/43) 💚
Files 91.919% (182/198) 👍
Classes 93.421% (426/456) 👍
Methods 89.3% (1085/1215) 👍
Lines 76.854% (13172/17139) 👍 0.049
Conditionals 100.0% (0/0) 💚

axw
axw approved these changes May 6, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to make this configurable in the integration package?

No. Users should be able to configure it through the YAML box in the Fleet output config. Eventually it should be self-tuning/adaptive

@marclop marclop added the v8.3.0 label May 6, 2022
@stuartnelson3 stuartnelson3 enabled auto-merge (squash) May 6, 2022 07:40
@stuartnelson3 stuartnelson3 merged commit 982e238 into elastic:main May 6, 2022
@axw axw self-assigned this Jun 7, 2022
mergify bot pushed a commit that referenced this pull request Jun 7, 2022
@stuartnelson3 @mergify
support output.elasticsearch.max_requests (#8055)
b7f30c4 
make the number of bulk requests in the
modelindexer configurable via
`output.elasticsearch.max_requests`

(cherry picked from commit 982e238)

# Conflicts:
#	changelogs/head.asciidoc
@mergify mergify bot mentioned this pull request Jun 7, 2022
Closed
@axw
Copy link
Copy Markdown
Member

axw commented Jun 7, 2022

Tested with 8.3.0 BC2, looks good. I only tested APM Server directly (query expvar), and didn't go through Fleet settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@axw axw axw approved these changes

Assignees

@axw axw

Labels

backport-8.3 Automated backport with mergify test-plan test-plan-ok v8.3.0

Projects

None yet

Milestone

8.3

Development

Successfully merging this pull request may close these issues.

Make output.elasticsearch.max_requests configurable

4 participants

@stuartnelson3 @axw @simitt @marclop