Merged
Conversation
227cf5d to
f91955f
Compare
marclop
approved these changes
Oct 27, 2021
mergify bot
pushed a commit
that referenced
this pull request
Nov 16, 2021
* modelindexer: optimise bulk response decoding * modelindexer: use fastjson for encoding meta * modelindexer: optimise event encoding (cherry picked from commit caf6ecb)
axw
added a commit
that referenced
this pull request
Nov 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation/summary
We currently still use reflection for both encoding and decoding. We should generate code for both the response decoding and for encoding events and requests.
Checklist
- [ ] Update CHANGELOG.asciidoc- [ ] Documentation has been updatedHow to test these changes
Non-functional change.
Related issues
#6360