Merged
Conversation
In elastic/kibana#95146 the response structure for listing APM agent central config changed. Update system tests to match.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
8967a97 to
c56fad6
Compare
elastic/elasticsearch#69322 added support for extracting device types to the user_agent ingest processors. Update approvals to match.
c56fad6 to
d188a77
Compare
Codecov Report
@@ Coverage Diff @@
## master #5037 +/- ##
=======================================
Coverage 77.23% 77.23%
=======================================
Files 178 178
Lines 10467 10467
=======================================
Hits 8084 8084
Misses 2383 2383 |
Member
Author
|
Trivial fix that only affects system tests, merging without review to unblock other PRs. |
mergify bot
pushed a commit
that referenced
this pull request
Mar 31, 2021
* tests/system: adapt to new API response In elastic/kibana#95146 the response structure for listing APM agent central config changed. Update system tests to match. * tests/system: add user_agent.device.type elastic/elasticsearch#69322 added support for extracting device types to the user_agent ingest processors. Update approvals to match. (cherry picked from commit 0e09aa6)
axw
added a commit
that referenced
this pull request
Apr 1, 2021
* tests/system: fix system tests (#5037) * tests/system: adapt to new API response In elastic/kibana#95146 the response structure for listing APM agent central config changed. Update system tests to match. * tests/system: add user_agent.device.type elastic/elasticsearch#69322 added support for extracting device types to the user_agent ingest processors. Update approvals to match. (cherry picked from commit 0e09aa6) * user_agent.device.type isn't in 7.x yet * make update * systemtest: revert approvals changes Co-authored-by: Andrew Wilkins <axw@elastic.co> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Fix Python-based system tests due to several recent changes:
user_agent.device.typeto approvals, which is now added by theuser_agentingest processorHow to test these changes
make system-testsRelated issues
None.