Add service name to dataset field#4674
Merged
jalvz merged 7 commits intoelastic:masterfrom Feb 16, 2021
Merged
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Steps errors
Expand to view the steps failures
|
15 tasks
51253fc to
5833656
Compare
simitt
approved these changes
Feb 15, 2021
model/metricset.go
Outdated
| fields[datastreams.DatasetField] = AppMetricsDataset | ||
| dataset = InternalMetricsDataset | ||
| } | ||
| dataset += "." + datastreams.NormalizeServiceName(me.Metadata.Service.Name) |
Contributor
There was a problem hiding this comment.
nit: Could you also use fmt.Sprintf here as everywhere else; it would only create one new string, instead of two.
Codecov Report
@@ Coverage Diff @@
## master #4674 +/- ##
==========================================
+ Coverage 76.78% 76.79% +0.01%
==========================================
Files 166 166
Lines 10232 10237 +5
==========================================
+ Hits 7857 7862 +5
Misses 2375 2375
|
axw
pushed a commit
to axw/apm-server
that referenced
this pull request
Feb 20, 2021
# Conflicts: # changelogs/head.asciidoc
axw
pushed a commit
to axw/apm-server
that referenced
this pull request
Feb 20, 2021
# Conflicts: # changelogs/head.asciidoc
axw
added a commit
that referenced
this pull request
Feb 20, 2021
axw
added a commit
that referenced
this pull request
Feb 20, 2021
v1v
added a commit
to v1v/apm-server
that referenced
this pull request
Feb 22, 2021
…chemas-to-agents * upstream/master: (111 commits) Introduce metricset.name (elastic#4857) processor/otel: test service.version handling (elastic#4853) docs: Add PHP agent information to shared docs (elastic#4740) Script for faster development workflow (elastic#4731) Update to elastic/beats@1b31c26 (elastic#4763) backport: add 7.12 to .backportrc.json (elastic#4807) backport: enable auto-merge on backport PRs (elastic#4777) Support for Node.js profiles (elastic#4728) docs: readds .NET link (elastic#4764) [DOCS] Fixes URLs on Secure communication with APM Agents page (elastic#4746) ci: set proper parameters for the tar step (elastic#4696) docs: add 7.11.1 release notes (elastic#4727) Disable sourcemap upload endpoint when data streams enabled (elastic#4735) Add service name to dataset field (elastic#4674) Update to elastic/beats@ba423212a660 (elastic#4733) sampling: require a default policy (elastic#4729) processor/otel: add unit test for span status (elastic#4734) Add support for consuming OTLP/gRPC metrics (elastic#4722) [apmpackage] Add config options supported in ESS (elastic#4690) Use the apm-server version everywhere* (elastic#4725) ...
v1v
added a commit
to v1v/apm-server
that referenced
this pull request
Feb 22, 2021
…te-schema-json-1 * upstream/master: (111 commits) Introduce metricset.name (elastic#4857) processor/otel: test service.version handling (elastic#4853) docs: Add PHP agent information to shared docs (elastic#4740) Script for faster development workflow (elastic#4731) Update to elastic/beats@1b31c26 (elastic#4763) backport: add 7.12 to .backportrc.json (elastic#4807) backport: enable auto-merge on backport PRs (elastic#4777) Support for Node.js profiles (elastic#4728) docs: readds .NET link (elastic#4764) [DOCS] Fixes URLs on Secure communication with APM Agents page (elastic#4746) ci: set proper parameters for the tar step (elastic#4696) docs: add 7.11.1 release notes (elastic#4727) Disable sourcemap upload endpoint when data streams enabled (elastic#4735) Add service name to dataset field (elastic#4674) Update to elastic/beats@ba423212a660 (elastic#4733) sampling: require a default policy (elastic#4729) processor/otel: add unit test for span status (elastic#4734) Add support for consuming OTLP/gRPC metrics (elastic#4722) [apmpackage] Add config options supported in ESS (elastic#4690) Use the apm-server version everywhere* (elastic#4725) ...
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (76.79%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #4674 +/- ##
==========================================
+ Coverage 76.78% 76.79% +0.01%
==========================================
Files 166 166
Lines 10232 10237 +5
==========================================
+ Hits 7857 7862 +5
Misses 2375 2375
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Implement the indexing strategy for APM data
Checklist
How to test these changes
Install APM package, send data to apm-server, and observe that data streams are created containing the ingested service names, and no legacy indices are created
Related issues
Closes #4492
Requires elastic/kibana#89870