Conversation
Similar to elastic/beats#22357, setup.template.overwrite could potentially overload Elasticsearch with too many update requests. On Elasticsearch side, it will be addressed in newer versions by introducing no-op updates which will be available from 7.11+ elastic/elasticsearch#64493 See also elastic/elasticsearch#57662 Thought having some warnings in the APM setting here should prevent users unwittingly leave template auto-creation on across large number of APM.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Steps errors
Expand to view the steps failures
|
|
Thanks @Leaf-Lin! I imagine that because APM Server is (currently) mostly deployed in smaller numbers, it wouldn't be such an issue. Once we move to running under Elastic Agent, on the edge, that would change; but we'll also be moving template management to Fleet then. Anyway, doesn't hurt to be cautious here. @bmorelli25 I'm not sure how/when we normally update these copied-from-beats docs, so I'll leave it to you. |
|
Thanks, @Leaf-Lin! This documentation is shared by both Beats and APM Server, with Beats being the source of truth. It looks like Naomi added this note to the Beats documentation recently, but we haven't updated the file on the APM side. Because APM Server programmatically updates documentation from Beats, committing this PR would only be temporary -- the contents would be overwritten on our next update. I've opened elastic/beats#22804 to address a few typos in the original PR. Once that is merged, I'll pull the changes into APM Server. In the meantime, I'll close this PR. Thanks again :) |
Motivation/summary
Similar to elastic/beats#22357, setup.template.overwrite could potentially overload Elasticsearch with too many update requests.
On Elasticsearch side, it will be addressed in newer versions by introducing no-op updates which will be available from 7.11+ elastic/elasticsearch#64493
See also elastic/elasticsearch#57662
Thought having some warnings in the APM setting here should prevent users unwittingly leave template auto-creation on across large number of APM.
Checklist
I have considered changes for: