Skip to content

Derive outcome from the HTTP status code when available#4165

Merged
jalvz merged 9 commits intoelastic:masterfrom
jalvz:derive-outcome
Sep 8, 2020
Merged

Derive outcome from the HTTP status code when available#4165
jalvz merged 9 commits intoelastic:masterfrom
jalvz:derive-outcome

Conversation

@jalvz
Copy link
Copy Markdown
Contributor

@jalvz jalvz commented Sep 7, 2020 •
edited
Loading

Motivation/summary

Avoid big empty charts in Kibana for error rates when user have ~old agents

Checklist

I have considered changes for:

How to test these changes

Related issues

Closes #4164

@jalvz
Copy link
Copy Markdown
Contributor Author

jalvz commented Sep 7, 2020 •
edited
Loading

Missing spec update (coming soon)

Spec: elastic/apm#338

@ghost
Copy link
Copy Markdown

ghost commented Sep 7, 2020 •
edited by ghost
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #4165 updated]

  • Start Time: 2020-09-08T09:16:51.111+0000

  • Duration: 44 min 47 sec

Test stats 🧪

Test Results
Failed 0
Passed 3273
Skipped 145
Total 3418

Steps errors

Expand to view the steps failures

  • Name: Compress

    • Description: tar --exclude=coverage-files.tgz -czf coverage-files.tgz coverage

    • Duration: 0 min 0 sec

    • Start Time: 2020-09-08T09:32:57.735+0000

    • log

  • Name: Compress

    • Description: tar --exclude=system-tests-linux-files.tgz -czf system-tests-linux-files.tgz system-tests

    • Duration: 0 min 0 sec

    • Start Time: 2020-09-08T09:45:52.445+0000

    • log

  • Name: Test Sync

    • Description: ./script/jenkins/sync.sh

    • Duration: 3 min 50 sec

    • Start Time: 2020-09-08T09:26:59.513+0000

    • log

axw
axw approved these changes Sep 7, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few minor things.

jalvz and others added 8 commits September 8, 2020 08:04
@jalvz @axw
Update model/modeldecoder/span_test.go
f81dff2 
Co-authored-by: Andrew Wilkins <axwalk@gmail.com>
@jalvz @axw
Update model/modeldecoder/span_test.go
64f7979 
Co-authored-by: Andrew Wilkins <axwalk@gmail.com>
@jalvz @axw
Update model/modeldecoder/span_test.go
8d5d1ff 
Co-authored-by: Andrew Wilkins <axwalk@gmail.com>
@jalvz @axw
Update model/modeldecoder/span_test.go
c497601 
Co-authored-by: Andrew Wilkins <axwalk@gmail.com>
@jalvz @axw
Update model/modeldecoder/span_test.go
69a3c87 
Co-authored-by: Andrew Wilkins <axwalk@gmail.com>
@jalvz
add comment
c805b35
@jalvz
add changelog
079d6d6
@jalvz
Merge branch 'master' into derive-outcome
0754f7b
@jalvz jalvz merged commit 7821e21 into elastic:master Sep 8, 2020
@jalvz jalvz mentioned this pull request Sep 9, 2020
Merged
jalvz added a commit to jalvz/apm-server that referenced this pull request Sep 9, 2020
@jalvz
Derive outcome from the HTTP status code when available (elastic#4165)
a88c86a
jalvz added a commit that referenced this pull request Sep 9, 2020
@jalvz
Derive outcome from the HTTP status code when available (#4165) (#4184)
44c2f65
@axw axw self-assigned this Oct 15, 2020
@axw
Copy link
Copy Markdown
Member

axw commented Oct 15, 2020

Tested BC1 using the Go agent v1.8.0, which does not send outcome.

package main

import (
        "net/http"

        "go.elastic.co/apm"
)

func main() {
        tracer := apm.DefaultTracer
        tx := tracer.StartTransaction("name", "type")
        span := tx.StartSpan("name", "type", nil)
        req, _ := http.NewRequest("GET", "http://testing.invalid", nil)
        span.Context.SetHTTPRequest(req)
        span.Context.SetHTTPStatusCode(200)
        span.End()
        tx.Context.SetHTTPStatusCode(400)
        tx.End()
        tracer.Flush(nil)
}

As expected:

  • With transaction's HTTP status code set to 400, event.outcome is "success"
  • With transaction's HTTP status code set to 500, event.outcome is "failure"
  • With span's HTTP status code set to 200, event.outcome is "success"
  • With span's HTTP status code set to 400, event.outcome is "failure"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@axw axw axw approved these changes

Assignees

@axw axw

Labels

test-plan test-plan-ok v7.10.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement fallback logic for event outcome to support older agents

2 participants

@jalvz @axw