intake: Add classname as stacktrace frame attribute#3096
Merged
simitt merged 4 commits intoelastic:masterfrom Jan 6, 2020
Merged
intake: Add classname as stacktrace frame attribute#3096simitt merged 4 commits intoelastic:masterfrom
simitt merged 4 commits intoelastic:masterfrom
Conversation
Require either classname or filename attribute for stacktrace frames on Intake API. This supports more native stacktrace frame representation for a couple of languages, e.g. Java and .NET. closes elastic#3006
Codecov Report
@@ Coverage Diff @@
## master #3096 +/- ##
======================================
Coverage 78.9% 78.9%
======================================
Files 97 97
Lines 5010 5010
======================================
Hits 3953 3953
Misses 1057 1057 |
axw
approved these changes
Jan 6, 2020
Co-Authored-By: Andrew Wilkins <axwalk@gmail.com>
simitt
added a commit
to simitt/apm-server
that referenced
this pull request
Jan 7, 2020
Require either classname or filename attribute for stacktrace frames on Intake API. This supports more native stacktrace frame representation for a couple of languages, e.g. Java and .NET. closes elastic#3006 Co-Authored-By: Andrew Wilkins <axwalk@gmail.com>
simitt
added a commit
that referenced
this pull request
Jan 7, 2020
) Require either classname or filename attribute for stacktrace frames on Intake API. This supports more native stacktrace frame representation for a couple of languages, e.g. Java and .NET. closes #3006 Co-Authored-By: Andrew Wilkins <axwalk@gmail.com>
dgieselaar
added a commit
to dgieselaar/kibana
that referenced
this pull request
Jan 13, 2020
In elastic/apm-server/pull/3096, an alternative to stacktrace.filename was introduced: stacktrace.classname. This change makes sure classname is properly represented in the UI and in our types.
dgieselaar
added a commit
to elastic/kibana
that referenced
this pull request
Jan 14, 2020
In elastic/apm-server/pull/3096, an alternative to stacktrace.filename was introduced: stacktrace.classname. This change makes sure classname is properly represented in the UI and in our types.
dgieselaar
added a commit
to dgieselaar/kibana
that referenced
this pull request
Jan 14, 2020
In elastic/apm-server/pull/3096, an alternative to stacktrace.filename was introduced: stacktrace.classname. This change makes sure classname is properly represented in the UI and in our types.
dgieselaar
added a commit
to elastic/kibana
that referenced
this pull request
Jan 14, 2020
In elastic/apm-server/pull/3096, an alternative to stacktrace.filename was introduced: stacktrace.classname. This change makes sure classname is properly represented in the UI and in our types.
jkelastic
pushed a commit
to jkelastic/kibana
that referenced
this pull request
Jan 17, 2020
In elastic/apm-server/pull/3096, an alternative to stacktrace.filename was introduced: stacktrace.classname. This change makes sure classname is properly represented in the UI and in our types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current format of stacktrace frames does not well reflect native stacktraces for all languages. Especially .NET and Java are missing a
classnameattribute. More detailed discussions can be found at elastic/kibana#49467. This PR adds support forclassnameas a property of a stacktrace frame.Intake API:
Adds support of
classnameas a valid property of a stacktrace frame to the Intake API. Requirements are changed, so that now either aclassnameor afilenameis required for a stacktrace frame.Calculating Error Grouping Key:
In case only
classnameis given, it will be used for calculating the grouping key, otherwise the calculation is not changed.Source mapping
The RUM agent does not make use of
classname, no changes are required for source mapping logic.closes #3006