[ACM] Only allow cache expiration values in full seconds.#2443
Merged
simitt merged 4 commits intoelastic:masterfrom Jul 12, 2019
Merged
[ACM] Only allow cache expiration values in full seconds.#2443simitt merged 4 commits intoelastic:masterfrom
simitt merged 4 commits intoelastic:masterfrom
Conversation
graphaelli
approved these changes
Jul 12, 2019
Member
graphaelli
left a comment
There was a problem hiding this comment.
looks good, even makes test confg fail if the value is bad. If we need this validation elsewhere we should pull it into a ucfg validator eg
apm-server/beater/config_helper.go
Line 30 in aa13cef
Member
|
Per discussion, we can update the integration test introduced in #2439 to check this. |
Contributor
Author
|
I generally agree regarding the |
simitt
added a commit
to simitt/apm-server
that referenced
this pull request
Jul 12, 2019
* [ACM] Only allow cache expiration values in full seconds. fixes elastic#2438
simitt
added a commit
to simitt/apm-server
that referenced
this pull request
Jul 12, 2019
* [ACM] Only allow cache expiration values in full seconds. fixes elastic#2438
graphaelli
pushed a commit
that referenced
this pull request
Jul 12, 2019
graphaelli
pushed a commit
that referenced
this pull request
Jul 12, 2019
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2438
backport to
7.xand7.3.