Merged
Conversation
simitt
approved these changes
Jul 4, 2019
Contributor
Author
|
sure, but https://github.com/elastic/apm-server/pull/2386/files#diff-ac43bed278b2a08583ad0db77c48b00bR155 is not enough? |
Contributor
|
Sure this test is great for the actual behavior. What I meant was adding a logging test, checking for Kibana disabled, similar to . With those tests we ensure that e.g. we don't lose information in the logs. |
endpoint when kibana is not configured
jalvz
added a commit
to jalvz/apm-server
that referenced
this pull request
Jul 5, 2019
…lastic#2386) endpoint when kibana is not configured
simitt
pushed a commit
to simitt/apm-server
that referenced
this pull request
Jul 8, 2019
…lastic#2386) endpoint when kibana is not configured
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2383