Add caching to Agent Remote Configuration handling#2337
Merged
simitt merged 10 commits intoelastic:masterfrom Jul 2, 2019
Merged
Add caching to Agent Remote Configuration handling#2337simitt merged 10 commits intoelastic:masterfrom
simitt merged 10 commits intoelastic:masterfrom
Conversation
jalvz
reviewed
Jun 27, 2019
Contributor
Either is fine by me, but you can also flip this statement on its head and say that this one is "stable" rather than "unmaintained" - not all software has to keep changing forever. Good job so far, thorough testing as always 💯 |
Contributor
Author
|
jenkins, run the tests please |
graphaelli
reviewed
Jul 1, 2019
jalvz
approved these changes
Jul 2, 2019
simitt
added a commit
to simitt/apm-server
that referenced
this pull request
Jul 2, 2019
* Add cache to agent config management closes elastic#2220
simitt
added a commit
that referenced
this pull request
Jul 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2220
I did look at a couple of different go caching libraries, but decided to go for the same one that we already use in the sourcemap handling, patrickmn/go-cache, to avoid adding new dependencies. Since this library hasn't changed in the last 2 years, we might want to consider moving to a more maintained one at some point. Before doing so we should have proper integration testing in place so we can run a macro benchmark rather than a micro benchmark, taking into account different cache expiration strategies of underlying cache implementations.