Add top level span and transaction to metricset.#2265
Merged
simitt merged 2 commits intoelastic:masterfrom Jun 12, 2019
Merged
Conversation
Metricsets can now store information about which transaction and span they belong to, allowing for better query and grouping experience. Closes elastic#2086
simitt
added a commit
to simitt/kibana
that referenced
this pull request
Jun 7, 2019
graphaelli
approved these changes
Jun 7, 2019
Member
|
Is this waiting for another approval or can it be merged? |
Contributor
Author
|
We have to wait until elastic/kibana#38411 is approved and merged. |
simitt
added a commit
to elastic/kibana
that referenced
this pull request
Jun 12, 2019
simitt
added a commit
to simitt/apm-server
that referenced
this pull request
Jun 12, 2019
simitt
added a commit
that referenced
this pull request
Jun 12, 2019
watson
added a commit
to watson/apm-agent-nodejs
that referenced
this pull request
Jun 12, 2019
These broke because 4 new files were added in: elastic/apm-server#2265
watson
added a commit
to elastic/apm-agent-nodejs
that referenced
this pull request
Jun 12, 2019
These broke because 4 new files were added in: elastic/apm-server#2265
3 tasks
jalvz
pushed a commit
to jalvz/apm-server
that referenced
this pull request
Jun 26, 2019
Metricsets can now store information about which transaction and span they belong to, allowing for better query and grouping experience. Closes elastic#2086
jalvz
pushed a commit
to jalvz/apm-server
that referenced
this pull request
Jun 26, 2019
Metricsets can now store information about which transaction and span they belong to, allowing for better query and grouping experience. Closes elastic#2086
jalvz
added a commit
that referenced
this pull request
Jun 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metricsets can now store information about which transaction and span they belong to, allowing for better query and grouping experience.
Closes #2086
cc @felixbarny