Skip to content

test: Fix flaky systemtest TestMonitoring#20697

Merged
carsonip merged 1 commit intoelastic:mainfrom
carsonip:fix-systemtest-testmonitoring
Mar 12, 2026
Merged

test: Fix flaky systemtest TestMonitoring#20697
carsonip merged 1 commit intoelastic:mainfrom
carsonip:fix-systemtest-testmonitoring

Conversation

@carsonip
Copy link
Copy Markdown
Member

@carsonip carsonip commented Mar 12, 2026 •
edited
Loading

Motivation/summary

Fix flaky systemtest TestMonitoring by asserting type not value

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

Fixes #20436

@carsonip carsonip requested a review from a team as a code owner March 12, 2026 16:37
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 12, 2026

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@carsonip carsonip force-pushed the fix-systemtest-testmonitoring branch from 90ea1a3 to b99bdb8 Compare March 12, 2026 16:38
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 12, 2026

This pull request does not have a backport label. Could you fix it @carsonip? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8.19 is the label to automatically backport to the 8.19 branch.
  • backport-9./d is the label to automatically backport to the 9./d branch. /d is the digit.
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@carsonip carsonip added backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches backport-active-8 Automated backport with mergify to all the active 8.[0-9]+ branches labels Mar 12, 2026
@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Mar 12, 2026

💚 Build Succeeded

@carsonip carsonip enabled auto-merge March 12, 2026 17:51
inge4pres
inge4pres approved these changes Mar 12, 2026
View reviewed changes
systemtest/monitoring_test.go
// output.events.active is an instantaneous gauge. It may be non-zero
// if there are other events, e.g. aggregated metrics, in flight.
// Therefore, we assert presence of output.events.active value but not its value.
assert.Equal(t, gjson.Number, gjson.GetBytes(metrics.Libbeat, "output.events.active").Type)
Copy link
Copy Markdown
Contributor

@inge4pres inge4pres Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍🏼

@carsonip carsonip added this pull request to the merge queue Mar 12, 2026
Merged via the queue into elastic:main with commit d4b4293 Mar 12, 2026
23 checks passed
@carsonip carsonip deleted the fix-systemtest-testmonitoring branch March 12, 2026 18:58
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 12, 2026

@Mergifyio backport 8.19 9.2 9.3

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 12, 2026 •
edited
Loading

backport 8.19 9.2 9.3

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Mar 12, 2026
@carsonip @mergify
test: Fix flaky systemtest TestMonitoring (#20697)
38b42dc 
(cherry picked from commit d4b4293)
@mergify mergify bot mentioned this pull request Mar 12, 2026
Merged
2 tasks
mergify bot pushed a commit that referenced this pull request Mar 12, 2026
@carsonip @mergify
test: Fix flaky systemtest TestMonitoring (#20697)
a1202dc 
(cherry picked from commit d4b4293)
@mergify mergify bot mentioned this pull request Mar 12, 2026
Merged
2 tasks
mergify bot pushed a commit that referenced this pull request Mar 12, 2026
@carsonip @mergify
test: Fix flaky systemtest TestMonitoring (#20697)
5b962f4 
(cherry picked from commit d4b4293)
@mergify mergify bot mentioned this pull request Mar 12, 2026
Merged
2 tasks
mergify bot added a commit that referenced this pull request Mar 12, 2026
@mergify @carsonip
test: Fix flaky systemtest TestMonitoring (#20697) (#20703)
2fd13f1 
(cherry picked from commit d4b4293)

Co-authored-by: Carson Ip <carsonip@users.noreply.github.com>
mergify bot added a commit that referenced this pull request Mar 12, 2026
@mergify @carsonip
test: Fix flaky systemtest TestMonitoring (#20697) (#20701)
2cafb5e 
(cherry picked from commit d4b4293)

Co-authored-by: Carson Ip <carsonip@users.noreply.github.com>
mergify bot added a commit that referenced this pull request Mar 12, 2026
@mergify @carsonip
test: Fix flaky systemtest TestMonitoring (#20697) (#20702)
4c4eef7 
(cherry picked from commit d4b4293)

Co-authored-by: Carson Ip <carsonip@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@inge4pres inge4pres inge4pres approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport-active-8 Automated backport with mergify to all the active 8.[0-9]+ branches backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test: Flaky systemtest monitoring_test TestMonitoring

3 participants

@carsonip @elasticmachine @inge4pres