TBS: Log pubsub errors at error or warn level#17135
Merged
carsonip merged 9 commits intoelastic:mainfrom Jun 10, 2025
Merged
Conversation
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
isaacaflores2
previously approved these changes
Jun 9, 2025
axw
previously approved these changes
Jun 10, 2025
rubvs
previously approved these changes
Jun 10, 2025
1pkg
approved these changes
Jun 10, 2025
Contributor
|
@Mergifyio backport 8.17 8.18 8.19 9.0 |
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 10, 2025
* Surface pubsub subscriber errors by logging at Warn level for 429 and Error level for others, instead of Debug level. Do not log context canceled. This may introduce noise to logs, e.g. when ES returns 429, but at worst it will only log one line every search interval (default = 1m/2 = 30s) which is acceptable. * Also change publisher logs from debug level to error level. (cherry picked from commit 6d41432) # Conflicts: # x-pack/apm-server/sampling/pubsub/checkpoints.go # x-pack/apm-server/sampling/pubsub/pubsub.go # x-pack/apm-server/sampling/pubsub/pubsub_test.go
1 task
mergify bot
pushed a commit
that referenced
this pull request
Jun 10, 2025
* Surface pubsub subscriber errors by logging at Warn level for 429 and Error level for others, instead of Debug level. Do not log context canceled. This may introduce noise to logs, e.g. when ES returns 429, but at worst it will only log one line every search interval (default = 1m/2 = 30s) which is acceptable. * Also change publisher logs from debug level to error level. (cherry picked from commit 6d41432) # Conflicts: # x-pack/apm-server/sampling/pubsub/checkpoints.go # x-pack/apm-server/sampling/pubsub/pubsub.go # x-pack/apm-server/sampling/pubsub/pubsub_test.go
1 task
mergify bot
pushed a commit
that referenced
this pull request
Jun 10, 2025
* Surface pubsub subscriber errors by logging at Warn level for 429 and Error level for others, instead of Debug level. Do not log context canceled. This may introduce noise to logs, e.g. when ES returns 429, but at worst it will only log one line every search interval (default = 1m/2 = 30s) which is acceptable. * Also change publisher logs from debug level to error level. (cherry picked from commit 6d41432) # Conflicts: # x-pack/apm-server/sampling/pubsub/pubsub_test.go
1 task
mergify bot
pushed a commit
that referenced
this pull request
Jun 10, 2025
* Surface pubsub subscriber errors by logging at Warn level for 429 and Error level for others, instead of Debug level. Do not log context canceled. This may introduce noise to logs, e.g. when ES returns 429, but at worst it will only log one line every search interval (default = 1m/2 = 30s) which is acceptable. * Also change publisher logs from debug level to error level. (cherry picked from commit 6d41432) # Conflicts: # x-pack/apm-server/sampling/pubsub/checkpoints.go # x-pack/apm-server/sampling/pubsub/pubsub.go # x-pack/apm-server/sampling/pubsub/pubsub_test.go
1 task
mergify bot
added a commit
that referenced
this pull request
Jun 10, 2025
…#17180) * TBS: Log pubsub errors at error or warn level (#17135) * Surface pubsub subscriber errors by logging at Warn level for 429 and Error level for others, instead of Debug level. Do not log context canceled. This may introduce noise to logs, e.g. when ES returns 429, but at worst it will only log one line every search interval (default = 1m/2 = 30s) which is acceptable. * Also change publisher logs from debug level to error level. (cherry picked from commit 6d41432) # Conflicts: # x-pack/apm-server/sampling/pubsub/checkpoints.go # x-pack/apm-server/sampling/pubsub/pubsub.go # x-pack/apm-server/sampling/pubsub/pubsub_test.go * Fix conflicts * Fix test conflict --------- Co-authored-by: Carson Ip <carsonip@users.noreply.github.com> Co-authored-by: Carson Ip <carson.ip@elastic.co>
mergify bot
added a commit
that referenced
this pull request
Jun 10, 2025
#17178) * TBS: Log pubsub errors at error or warn level (#17135) * Surface pubsub subscriber errors by logging at Warn level for 429 and Error level for others, instead of Debug level. Do not log context canceled. This may introduce noise to logs, e.g. when ES returns 429, but at worst it will only log one line every search interval (default = 1m/2 = 30s) which is acceptable. * Also change publisher logs from debug level to error level. (cherry picked from commit 6d41432) # Conflicts: # x-pack/apm-server/sampling/pubsub/checkpoints.go # x-pack/apm-server/sampling/pubsub/pubsub.go # x-pack/apm-server/sampling/pubsub/pubsub_test.go * Fix conflicts * Fix test conflict --------- Co-authored-by: Carson Ip <carsonip@users.noreply.github.com> Co-authored-by: Carson Ip <carson.ip@elastic.co>
mergify bot
added a commit
that referenced
this pull request
Jun 10, 2025
#17177) * TBS: Log pubsub errors at error or warn level (#17135) * Surface pubsub subscriber errors by logging at Warn level for 429 and Error level for others, instead of Debug level. Do not log context canceled. This may introduce noise to logs, e.g. when ES returns 429, but at worst it will only log one line every search interval (default = 1m/2 = 30s) which is acceptable. * Also change publisher logs from debug level to error level. (cherry picked from commit 6d41432) # Conflicts: # x-pack/apm-server/sampling/pubsub/checkpoints.go # x-pack/apm-server/sampling/pubsub/pubsub.go # x-pack/apm-server/sampling/pubsub/pubsub_test.go * Fix conflicts * Fix test conflict * Do not use logptest.NewTestingLogger --------- Co-authored-by: Carson Ip <carsonip@users.noreply.github.com> Co-authored-by: Carson Ip <carson.ip@elastic.co>
mergify bot
added a commit
that referenced
this pull request
Jun 11, 2025
#17179) * TBS: Log pubsub errors at error or warn level (#17135) * Surface pubsub subscriber errors by logging at Warn level for 429 and Error level for others, instead of Debug level. Do not log context canceled. This may introduce noise to logs, e.g. when ES returns 429, but at worst it will only log one line every search interval (default = 1m/2 = 30s) which is acceptable. * Also change publisher logs from debug level to error level. (cherry picked from commit 6d41432) # Conflicts: # x-pack/apm-server/sampling/pubsub/pubsub_test.go * Fix merge conflict * Bump elastic-agent-libs to fix failing test * make notice --------- Co-authored-by: Carson Ip <carsonip@users.noreply.github.com> Co-authored-by: Carson Ip <carson.ip@elastic.co> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Checklist
- [ ] Update CHANGELOG.asciidocto be done on releaseFor functional changes, consider:
How to test these changes
Covered by unit tests
Related issues
Fixes #17117