TBS: Add sampling.tail.discard_on_write_failure config#15159
Merged
carsonip merged 9 commits intoelastic:mainfrom Jan 7, 2025
Merged
TBS: Add sampling.tail.discard_on_write_failure config#15159carsonip merged 9 commits intoelastic:mainfrom
sampling.tail.discard_on_write_failure config#15159carsonip merged 9 commits intoelastic:mainfrom
Conversation
Contributor
|
This pull request does not have a backport label. Could you fix it @carsonip? 🙏
|
Contributor
|
|
carsonip
commented
Jan 7, 2025
1pkg
previously approved these changes
Jan 7, 2025
Contributor
1pkg
left a comment
There was a problem hiding this comment.
It would be really nice to have a test for DiscardOnWriteFailure case.
1pkg
approved these changes
Jan 7, 2025
mergify bot
pushed a commit
that referenced
this pull request
Jan 7, 2025
Add config sampling.tail.discard_on_write_failure (default=false) for users to opt in to data loss when TBS storage limit is reached, as an escape hatch when increased ES indexing load is unacceptable. (cherry picked from commit 9b40574)
mergify bot
pushed a commit
that referenced
this pull request
Jan 7, 2025
Add config sampling.tail.discard_on_write_failure (default=false) for users to opt in to data loss when TBS storage limit is reached, as an escape hatch when increased ES indexing load is unacceptable. (cherry picked from commit 9b40574)
mergify bot
pushed a commit
that referenced
this pull request
Jan 7, 2025
Add config sampling.tail.discard_on_write_failure (default=false) for users to opt in to data loss when TBS storage limit is reached, as an escape hatch when increased ES indexing load is unacceptable. (cherry picked from commit 9b40574)
mergify bot
added a commit
that referenced
this pull request
Jan 7, 2025
…5172) Add config sampling.tail.discard_on_write_failure (default=false) for users to opt in to data loss when TBS storage limit is reached, as an escape hatch when increased ES indexing load is unacceptable. (cherry picked from commit 9b40574) Co-authored-by: Carson Ip <carsonip@users.noreply.github.com>
mergify bot
added a commit
that referenced
this pull request
Jan 7, 2025
…5170) Add config sampling.tail.discard_on_write_failure (default=false) for users to opt in to data loss when TBS storage limit is reached, as an escape hatch when increased ES indexing load is unacceptable. (cherry picked from commit 9b40574) Co-authored-by: Carson Ip <carsonip@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mergify bot
added a commit
that referenced
this pull request
Jan 7, 2025
…5171) Add config sampling.tail.discard_on_write_failure (default=false) for users to opt in to data loss when TBS storage limit is reached, as an escape hatch when increased ES indexing load is unacceptable. (cherry picked from commit 9b40574) Co-authored-by: Carson Ip <carsonip@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Add config
sampling.tail.discard_on_write_failure(default=false) for users to opt in to data loss when TBS storage limit is reached, as an escape hatch when increased ES indexing load is unacceptable.Checklist
- [ ] Update CHANGELOG.asciidocbackported- [ ] Documentation has been updatedintentionally undocumentedFor functional changes, consider:
How to test these changes
Enable TBS, trigger storage limit reached, check if behavior aligns with config = {true, false}
Related issues
Fixes #11127