Skip to content

docs: Document sampling behavior on TBS storage limit reached#11663

Merged
carsonip merged 2 commits intoelastic:mainfrom
carsonip:tbs-on-process-batch-fail
Sep 20, 2023
Merged

docs: Document sampling behavior on TBS storage limit reached#11663
carsonip merged 2 commits intoelastic:mainfrom
carsonip:tbs-on-process-batch-fail

Conversation

@carsonip
Copy link
Member

@carsonip carsonip commented Sep 18, 2023 •
edited
Loading

Motivation/summary

Document sampling behavior on TBS storage limit reached.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

Closes #11126

@carsonip carsonip requested a review from a team as a code owner September 18, 2023 16:28
@carsonip
Copy link
Member Author

carsonip commented Sep 18, 2023

how far should we backport this doc improvement?

@mergify
Copy link
Contributor

mergify bot commented Sep 18, 2023

This pull request does not have a backport label. Could you fix it @carsonip? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Sep 18, 2023
@kruskall
Copy link
Member

kruskall commented Sep 18, 2023

Should we backport this ?

@carsonip carsonip added backport-8.8 Automated backport with mergify backport-8.9 Automated backport with mergify backport-8.10 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Sep 20, 2023
@carsonip
Copy link
Member Author

carsonip commented Sep 20, 2023

backporting to 8.8+ since docs/configure/sampling.asciidoc only existed since 8.8.

@carsonip carsonip merged commit f33e218 into elastic:main Sep 20, 2023
mergify bot pushed a commit that referenced this pull request Sep 20, 2023
@carsonip @mergify
docs: Document sampling behavior on TBS storage limit reached (#11663)
a6c06a8 
Document sampling behavior on TBS storage limit reached.

(cherry picked from commit f33e218)
mergify bot pushed a commit that referenced this pull request Sep 20, 2023
@carsonip @mergify
docs: Document sampling behavior on TBS storage limit reached (#11663)
d6f7db9 
Document sampling behavior on TBS storage limit reached.

(cherry picked from commit f33e218)
mergify bot pushed a commit that referenced this pull request Sep 20, 2023
@carsonip @mergify
docs: Document sampling behavior on TBS storage limit reached (#11663)
0e4f354 
Document sampling behavior on TBS storage limit reached.

(cherry picked from commit f33e218)
This was referenced Sep 20, 2023
Merged
Merged
Merged
mergify bot added a commit that referenced this pull request Sep 20, 2023
@mergify @carsonip
docs: Document sampling behavior on TBS storage limit reached (#11663) (
2e377c4 
#11679)

Document sampling behavior on TBS storage limit reached.

(cherry picked from commit f33e218)

Co-authored-by: Carson Ip <carsonip@users.noreply.github.com>
mergify bot added a commit that referenced this pull request Sep 20, 2023
@mergify @carsonip
docs: Document sampling behavior on TBS storage limit reached (#11663) (
4b4214e 
#11680)

Document sampling behavior on TBS storage limit reached.

(cherry picked from commit f33e218)

Co-authored-by: Carson Ip <carsonip@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mergify bot added a commit that referenced this pull request Sep 25, 2023
@mergify @carsonip
docs: Document sampling behavior on TBS storage limit reached (#11663) (
f689fbf 
#11678)

Document sampling behavior on TBS storage limit reached.

(cherry picked from commit f33e218)

Co-authored-by: Carson Ip <carsonip@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marclop marclop marclop approved these changes

+1 more reviewer

@kruskall kruskall kruskall approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport-8.8 Automated backport with mergify backport-8.9 Automated backport with mergify backport-8.10 Automated backport with mergify

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document the behaviour of TBS on failure to process batch

3 participants

@carsonip @kruskall @marclop