This repository was archived by the owner on Jan 23, 2024. It is now read-only.
fix: skip chrome and firefox downloads on the RUM agent Docker image#965
Merged
kuisathaverat merged 4 commits intoelastic:masterfrom Nov 12, 2020
Merged
fix: skip chrome and firefox downloads on the RUM agent Docker image#965kuisathaverat merged 4 commits intoelastic:masterfrom
kuisathaverat merged 4 commits intoelastic:masterfrom
Conversation
kuisathaverat
commented
Nov 9, 2020
v1v
approved these changes
Nov 9, 2020
vigneshshanmugam
approved these changes
Nov 9, 2020
cachedout
approved these changes
Nov 9, 2020
mdelapenya
approved these changes
Nov 9, 2020
Contributor
Author
|
I am checking why the change causes the following error on the RUM agent |
Member
|
Seems like to me the browser process is not getting killed. |
Contributor
Author
|
this message from the documentation seems relevant |
Contributor
Author
|
Contributor
Author
|
I finally decided to run things step by step, and I've found why chrome/chromium versions from finaries does not work, they are compiled with dbus support, we do not have dbus running on the containers, fortunetly the chromium version provided by debian main repositories is not compiled with that option, and it works. So finally, we stop installing chrome from the google nightlys, and we stop downloading the puppeteer chrome version, we replace both by the standard chromium package. |
kuisathaverat
added a commit
to kuisathaverat/apm-integration-testing
that referenced
this pull request
Nov 12, 2020
…lastic#965) * fix: skip chrome and firefox downloads on the RUM agent Docker image * test: rerun test on test-all * fix: use debian chromium package * chore: remove comments # Conflicts: # docker/rum/Dockerfile
kuisathaverat
added a commit
to kuisathaverat/apm-integration-testing
that referenced
this pull request
Nov 12, 2020
…lastic#965) * fix: skip chrome and firefox downloads on the RUM agent Docker image * test: rerun test on test-all * fix: use debian chromium package * chore: remove comments # Conflicts: # docker/rum/Dockerfile
v1v
added a commit
to v1v/apm-integration-testing
that referenced
this pull request
Dec 16, 2020
* upstream/6.x: (22 commits) fix: skip chrome and firefox downloads on the RUM agent Docker image (elastic#965) (elastic#977) fix: change to use adoptOpenJDK to fix the build (elastic#944) (elastic#945) [6.x] fix: increase the resilience against network issues (elastic#927) (elastic#929) fix: use Node.js LTS version for ITs (elastic#921) (elastic#924) fix: RUM Docker image build (elastic#915) fix: update JDK and apply some maven options (elastic#904) (elastic#911) fix: use fixed version of setuptools (elastic#907) (elastic#909) fix: missing dependencies for rum test (elastic#899) (elastic#903) fix: update Go version to the latest LTS version (elastic#891) fix: add libxss dependency to the opbean-rum (elastic#880) (elastic#882) fix: remove chrome drive is not used (elastic#876) fix: update dependencies to run integration tests (elastic#872) (elastic#874) feat: bump pytest version (elastic#866) (elastic#868) test: add 6.x version to the test (elastic#651) (rum): run build on all RUM packages (elastic#622) feat: disable shallow cloning when using downstream pipelines (elastic#583) (elastic#585) [6.x] feat: pre-commit config (elastic#547) (elastic#549) fix: update build status badge ci: remove jenkinsfile feat: delete legacy integration testing jobs (elastic#542) ...
v1v
added a commit
to v1v/apm-integration-testing
that referenced
this pull request
Jan 8, 2021
* upstream/6.x: (23 commits) Bump 6.8 release (elastic#1007) fix: skip chrome and firefox downloads on the RUM agent Docker image (elastic#965) (elastic#977) fix: change to use adoptOpenJDK to fix the build (elastic#944) (elastic#945) [6.x] fix: increase the resilience against network issues (elastic#927) (elastic#929) fix: use Node.js LTS version for ITs (elastic#921) (elastic#924) fix: RUM Docker image build (elastic#915) fix: update JDK and apply some maven options (elastic#904) (elastic#911) fix: use fixed version of setuptools (elastic#907) (elastic#909) fix: missing dependencies for rum test (elastic#899) (elastic#903) fix: update Go version to the latest LTS version (elastic#891) fix: add libxss dependency to the opbean-rum (elastic#880) (elastic#882) fix: remove chrome drive is not used (elastic#876) fix: update dependencies to run integration tests (elastic#872) (elastic#874) feat: bump pytest version (elastic#866) (elastic#868) test: add 6.x version to the test (elastic#651) (rum): run build on all RUM packages (elastic#622) feat: disable shallow cloning when using downstream pipelines (elastic#583) (elastic#585) [6.x] feat: pre-commit config (elastic#547) (elastic#549) fix: update build status badge ci: remove jenkinsfile ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
it skips chrome download from puppeteer install, and skips browsers download from playwright install.
Why is it important?
Those downloads are not needed and impact the build time and the resilience of the build.