This repository was archived by the owner on Jan 23, 2024. It is now read-only.
docker/opbeans/go: strip vN from replacement path#1401
Merged
axw merged 1 commit intoelastic:mainfrom Jan 25, 2022
Merged
Conversation
When replacing go.elastic.co/apm modules for opbeans-go, strip the trailing /vN (e.g. /v2) from the module paths to form the directory structure. The version suffix is only present in module files, not in the directory structure.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 25, 2022
When replacing go.elastic.co/apm modules for opbeans-go, strip the trailing /vN (e.g. /v2) from the module paths to form the directory structure. The version suffix is only present in module files, not in the directory structure. (cherry picked from commit ed30b62)
axw
added a commit
that referenced
this pull request
Jan 25, 2022
When replacing go.elastic.co/apm modules for opbeans-go, strip the trailing /vN (e.g. /v2) from the module paths to form the directory structure. The version suffix is only present in module files, not in the directory structure. (cherry picked from commit ed30b62) Co-authored-by: Andrew Wilkins <axw@elastic.co>
v1v
added a commit
to v1v/apm-integration-testing
that referenced
this pull request
Feb 3, 2022
…main-reference * upstream/main: Update dockerfile for opbeans-dotnet to use .NET6 (elastic#1423) versions: wrong versions (elastic#1414) Update dockerfile for .NET test to use .NET6 (elastic#1412) apm: Neutral naming for apm-agent-java (elastic#1375) docker/go: use go.elastic.co/apm/v2 (elastic#1403) docker/opbeans/go: strip vN from replacement path (elastic#1401)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When replacing go.elastic.co/apm modules for opbeans-go, strip the trailing /vN (e.g. /v2) from the module paths to form the directory structure. The version suffix is only present in module files, not in the directory structure.
Why is it important?
This will be required to replace modules to a local checkout when we add
/v2suffixes to APM Agent modules.Related issues
Related to elastic/apm-agent-go#1184