fix(rum): publish all packages as transpiled modules#432
Merged
hmdhk merged 7 commits intoelastic:masterfrom Sep 30, 2019
Merged
fix(rum): publish all packages as transpiled modules#432hmdhk merged 7 commits intoelastic:masterfrom
hmdhk merged 7 commits intoelastic:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #432 +/- ##
==========================================
+ Coverage 93.84% 93.91% +0.06%
==========================================
Files 39 40 +1
Lines 1820 1889 +69
Branches 363 372 +9
==========================================
+ Hits 1708 1774 +66
- Misses 109 112 +3
Partials 3 3
|
Member
Author
|
Integration test failure is related to elastic/apm-integration-testing#600 |
271b1c9 to
d9ace70
Compare
hmdhk
reviewed
Sep 25, 2019
Contributor
hmdhk
left a comment
There was a problem hiding this comment.
Thanks @vigneshshanmugam , Generally looks good! I think it's good that we're testing against the actual dist folder but maybe we can change the output of the temporary files!
hmdhk
approved these changes
Sep 30, 2019
David-Development
pushed a commit
to David-Development/apm-agent-rum-js
that referenced
this pull request
Oct 20, 2021
* fix(rum): publish all packages as transpiled modules * add bundle tests for main and module * ignore bundle tests from karma * fix bundlesize script * optimize the build runs for test * fix rum src path * use tmp folder for bundle test and separate test
devcorpio
pushed a commit
to bmorelli25/apm-agent-rum-js
that referenced
this pull request
Jan 25, 2022
* fix(rum): publish all packages as transpiled modules * add bundle tests for main and module * ignore bundle tests from karma * fix bundlesize script * optimize the build runs for test * fix rum src path * use tmp folder for bundle test and separate test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
babel-preset-envwith the least supported environment which is Internal Explorer 11Most of the bundlers prefer
moduleovermainsince it can do better tree-shaking on ES6 modules which would reduce the code size.This would allow users to not configure babel for
@elastic/*modules which might be painful since users might need to be aware of the features/proposals that are used by the RUM library.TODO