Merged
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
estolfo
approved these changes
Jun 20, 2022
Contributor
estolfo
left a comment
There was a problem hiding this comment.
Looks good but tests are failing so we should get them fixed before merging.
jaggederest
commented
Jun 23, 2022
cfe1b3b to
8d13661
Compare
6f223f9 to
aeb7b3a
Compare
estolfo
pushed a commit
that referenced
this pull request
Mar 2, 2023
* Add span links to span context * Fix broken conflict and add spec for span links * Proper layout of linked spans in span context * Add comment about proposed location of span links for actual messaging use
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Implements a span links api to allow linkage of non-parent spans (e.g. originating asynchronous spans) to spans via a span context
Why is it important?
This is a part of the open telemetry spec as seen here: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/overview.md#links-between-spans
It will also be useful in future for e.g. SQS or RabbitMQ instrumentation
Checklist
.rubocop.yml)Related issues