implement transaction_ignore_urls#923
Merged
beniwohli merged 28 commits intoelastic:masterfrom Nov 17, 2020
Merged
Conversation
(and fixed issues revealed by the tests...)
This implements elastic/apm#299. Additionally, the "status_code" attribute has been added to HTTP spans.
# Conflicts: # elasticapm/instrumentation/packages/tornado.py # tests/contrib/asyncio/tornado/tornado_tests.py # tests/contrib/django/django_tests.py
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
6 tasks
b1e4651 to
d3a6ba7
Compare
basepi
approved these changes
Sep 24, 2020
Contributor
basepi
left a comment
There was a problem hiding this comment.
Looks great! Excellent testing coverage! 👍
elasticapm/conf/__init__.py
Outdated
| autoinsert_django_middleware = _BoolConfigValue("AUTOINSERT_DJANGO_MIDDLEWARE", default=True) | ||
| transactions_ignore_patterns = _ListConfigValue("TRANSACTIONS_IGNORE_PATTERNS", default=[]) | ||
| transaction_ignore_urls = _ListConfigValue("TRANSACTION_IGNORE_URLS", type=starmatch_to_regex, default=[]) | ||
|
|
Contributor
There was a problem hiding this comment.
Any particular reason we have an extra line here?
| @@ -108,7 +108,10 @@ def get_current_url(environ, root_only=False, strip_querystring=False, host_only | |||
| :param strip_querystring: set to `True` if you don't want the querystring. | |||
| :param host_only: set to `True` if the host URL should be returned. | |||
Contributor
There was a problem hiding this comment.
Can you please add path_only to the docstring?
| import pytest | ||
|
|
||
|
|
||
| def pytest_generate_tests(metafunc): |
Contributor
There was a problem hiding this comment.
Learned something new today! Didn't know about this pytest feature. 👍
🐛 Flaky test report❕ There are test failures but not known flaky tests. Expand to view the summary
Test stats 🧪
Genuine test errors
💔 There are test failures but not known flaky tests, most likely a genuine test failure.
|
beniwohli
added a commit
to beniwohli/apm-agent-python
that referenced
this pull request
Sep 14, 2021
* handle transaction_ignore_urls setting [WIP] * added framework specific tests (and fixed issues revealed by the tests...) * implement "outcome" property for transactions and spans This implements elastic/apm#299. Additionally, the "status_code" attribute has been added to HTTP spans. * fix some tests * change default outcome for spans to "unknown" * added API functions for setting transaction outcome * rework outcome API, and make sure it works for unsampled transactions * fix some tests * fix a test and add one for testing override behavior * add an override=False that went forgotten * expand docs a bit * implement transaction_ignore_urls [WIP] * do less work in aiohttp if we're not tracing a transaction * construct path to json tests in a platform independent way * fix merge issues * address review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Building on #773, implement
transaction_ignore_urlsRelated issues
closes #772