implement "outcome" property for transactions and spans#899
Merged
beniwohli merged 11 commits intoelastic:masterfrom Aug 25, 2020
Merged
implement "outcome" property for transactions and spans#899beniwohli merged 11 commits intoelastic:masterfrom
beniwohli merged 11 commits intoelastic:masterfrom
Conversation
This implements elastic/apm#299. Additionally, the "status_code" attribute has been added to HTTP spans.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
|
basepi
reviewed
Aug 11, 2020
Contributor
basepi
left a comment
There was a problem hiding this comment.
This looks good so far. One comment below.
felixbarny
reviewed
Aug 18, 2020
felixbarny
approved these changes
Aug 24, 2020
Member
felixbarny
left a comment
There was a problem hiding this comment.
LGTM
The only thing I'd add is more docs around the semantics of the individual status values and how they affect error rate calculation. The spec PR has some details on that but having that on the API docs will make that more discoverable. Either add on the set_transaction_outcome docs or on the OUTCOME constants, plus on the API docs.
basepi
approved these changes
Aug 24, 2020
8 tasks
7 tasks
Contributor
Author
|
@felixbarny does 0124d6873 address your comment on documentation? |
Member
|
It does! |
Contributor
Author
basepi
added a commit
to basepi/apm-agent-python
that referenced
this pull request
Aug 25, 2020
basepi
added a commit
that referenced
this pull request
Aug 25, 2020
* Add instrumentation for httpx * Add instrumentation for httpx.Client and httpx.AsyncClient * Add to changelog * Add link to PR in changelog * Update link in changelog * Add 0.12 to the jenkins_framework_full * Add some initial tests (based on requests tests) * Rename session test * Add httpcore sync and async instrumentations * Test fixes for httpx * Add async httpx tests * Add httpx.sh to properly set the pytest marker * Remove some copy pasta * Add review fixes * Add outcome to httpx spans * Add changelog for #899 Co-authored-by: HenrikOssipoff <henrik.ossipoff@gmail.com>
romulorosa
pushed a commit
to romulorosa/apm-agent-python
that referenced
this pull request
Oct 15, 2020
romulorosa
pushed a commit
to romulorosa/apm-agent-python
that referenced
this pull request
Oct 15, 2020
* Add instrumentation for httpx * Add instrumentation for httpx.Client and httpx.AsyncClient * Add to changelog * Add link to PR in changelog * Update link in changelog * Add 0.12 to the jenkins_framework_full * Add some initial tests (based on requests tests) * Rename session test * Add httpcore sync and async instrumentations * Test fixes for httpx * Add async httpx tests * Add httpx.sh to properly set the pytest marker * Remove some copy pasta * Add review fixes * Add outcome to httpx spans * Add changelog for elastic#899 Co-authored-by: HenrikOssipoff <henrik.ossipoff@gmail.com>
romulorosa
pushed a commit
to romulorosa/apm-agent-python
that referenced
this pull request
Oct 15, 2020
romulorosa
pushed a commit
to romulorosa/apm-agent-python
that referenced
this pull request
Oct 15, 2020
* Add instrumentation for httpx * Add instrumentation for httpx.Client and httpx.AsyncClient * Add to changelog * Add link to PR in changelog * Update link in changelog * Add 0.12 to the jenkins_framework_full * Add some initial tests (based on requests tests) * Rename session test * Add httpcore sync and async instrumentations * Test fixes for httpx * Add async httpx tests * Add httpx.sh to properly set the pytest marker * Remove some copy pasta * Add review fixes * Add outcome to httpx spans * Add changelog for elastic#899 Co-authored-by: HenrikOssipoff <henrik.ossipoff@gmail.com>
beniwohli
added a commit
to beniwohli/apm-agent-python
that referenced
this pull request
Sep 14, 2021
beniwohli
pushed a commit
to beniwohli/apm-agent-python
that referenced
this pull request
Sep 14, 2021
* Add instrumentation for httpx * Add instrumentation for httpx.Client and httpx.AsyncClient * Add to changelog * Add link to PR in changelog * Update link in changelog * Add 0.12 to the jenkins_framework_full * Add some initial tests (based on requests tests) * Rename session test * Add httpcore sync and async instrumentations * Test fixes for httpx * Add async httpx tests * Add httpx.sh to properly set the pytest marker * Remove some copy pasta * Add review fixes * Add outcome to httpx spans * Add changelog for elastic#899 Co-authored-by: HenrikOssipoff <henrik.ossipoff@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements elastic/apm#299.
Additionally, the "status_code" attribute has been added to HTTP spans.