Add field_name to ConfigurationError messages on init#2133
Merged
xrmx merged 4 commits intoelastic:mainfrom Dec 24, 2024
Merged
Add field_name to ConfigurationError messages on init#2133xrmx merged 4 commits intoelastic:mainfrom
xrmx merged 4 commits intoelastic:mainfrom
Conversation
|
💚 CLA has been signed |
Contributor
Author
|
Signed CLA |
Member
|
@radupotop thanks for the PR, please run black on it and I'll review it |
xrmx
approved these changes
Dec 24, 2024
Member
xrmx
left a comment
There was a problem hiding this comment.
Thanks for the PR, looks like a nice improvement
Member
|
run docs-build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Make
ConfigurationErrormessages more descriptive on init. This is especially useful where ENV variables are not set.Turns this error message:
into this: