Conversation
reakaleek
previously approved these changes
May 28, 2024
xrmx
previously approved these changes
May 28, 2024
v1v
commented
May 28, 2024
.github/workflows/updatecli.yml
Outdated
| vaultSecretId: ${{ secrets.VAULT_SECRET_ID }} | ||
| slackChannel: "#apm-agent-python" | ||
| command: "apply --config .ci/updatecli/updatecli.d --values .ci/updatecli/values.yml" | ||
| slack-bot-token: ${{ secrets.SLACK_BOT_TOKEN }} |
Member
Author
There was a problem hiding this comment.
I need to create this secret, I'm working on it
xrmx
approved these changes
May 31, 2024
xrmx
pushed a commit
to xrmx/apm-agent-python
that referenced
this pull request
Jun 10, 2024
xrmx
pushed a commit
to xrmx/apm-agent-python
that referenced
this pull request
Jun 10, 2024
xrmx
pushed a commit
that referenced
this pull request
Jun 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Use GitHub secrets rather than Vault secrets