Conversation
v1v
commented
Mar 25, 2024
.github/workflows/packages.yml
Outdated
Comment on lines
+31
to
+32
| - name: Build packages | ||
| run: ./dev-utils/make-packages.sh |
Member
Author
There was a problem hiding this comment.
This should help with reusing the script somewhere else and do some post-build steps
v1v
commented
Mar 25, 2024
| needs: | ||
| - build-distribution | ||
| runs-on: ubuntu-latest | ||
| permissions: |
| if [ "${{ startsWith(github.ref, 'refs/tags') }}" == "false" ] ; then | ||
| # for testing purposes | ||
| echo "tag=test" >> "${GITHUB_OUTPUT}" | ||
| echo "latest=test-latest" >> "${GITHUB_OUTPUT}" |
Member
Author
There was a problem hiding this comment.
To help with creating docker images on the fly and use them even for testing the release in a feature branch or main.
| if: startsWith(github.ref, 'refs/tags') | ||
| run: |- | ||
| docker push --all-tags ${{ env.DOCKER_IMAGE_NAME }} | ||
| - name: Build and push image |
Member
Author
There was a problem hiding this comment.
Required for the attestation
| secret/observability-team/ci/service-account/apm-agent-python access_key_id | AWS_ACCESS_KEY_ID ; | ||
| secret/observability-team/ci/service-account/apm-agent-python secret_access_key | AWS_SECRET_ACCESS_KEY | ||
| - uses: actions/download-artifact@v3 | ||
| - uses: actions/download-artifact@v4 |
.github/workflows/release.yml
Outdated
| - "v*.*.*" | ||
| branches: | ||
| - main | ||
| - feature/sbom |
v1v
commented
Apr 22, 2024
reakaleek
approved these changes
Apr 23, 2024
xrmx
approved these changes
Apr 23, 2024
trentm
reviewed
Apr 23, 2024
| - name: Attest image | ||
| uses: github-early-access/generate-build-provenance@main | ||
| with: | ||
| subject-name: "${{ env.DOCKER_IMAGE_NAME }}:${{ steps.setup-docker.outputs.tag }}" |
Member
There was a problem hiding this comment.
... Do NOT include a tag as part of the image name -- the specific image being attested is identified by the supplied digest. ...
Member
Author
There was a problem hiding this comment.
Interestingly, it works as is:
https://github.com/elastic/apm-agent-python/attestations/739913
xrmx
pushed a commit
to xrmx/apm-agent-python
that referenced
this pull request
May 17, 2024
xrmx
pushed a commit
to xrmx/apm-agent-python
that referenced
this pull request
May 20, 2024
xrmx
pushed a commit
that referenced
this pull request
May 24, 2024
xrmx
pushed a commit
to xrmx/apm-agent-python
that referenced
this pull request
Jun 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Use https://github.com/github-early-access/generate-build-provenance to create build attestations for binaries and docker images
https://github.com/elastic/apm-agent-python/attestations is the one with the different executions.