only use content-type and content-encoding headers for POSTing events#1651
Merged
basepi merged 2 commits intoelastic:mainfrom Oct 3, 2022
Merged
only use content-type and content-encoding headers for POSTing events#1651basepi merged 2 commits intoelastic:mainfrom
basepi merged 2 commits intoelastic:mainfrom
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
basepi
approved these changes
Oct 3, 2022
v1v
added a commit
to v1v/apm-agent-python
that referenced
this pull request
Oct 11, 2022
…ith-k8s-skaffold * upstream/main: bump python versions and use docker slim versions (elastic#1661) use github actions for pre-commit checks (elastic#1658) Use typing.TypeVar on decorators' type hints (elastic#1655) Use minimum of 5 seconds for interval between central config calls (elastic#1652) fix errors in pymongo tests introduced in elastic#1639 (elastic#1648) only use content-type and content-encoding headers for POSTing events (elastic#1651) fix starlette 0.21 tests (elastic#1653)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
As @trentm reported in #1634, our agent sends headers with the version sniffing request that don't really make sense. We previously fixed a similar issue for the
get-configrequest (#783). To avoid similar issues in the future, these two headers are now added explicitly when POSTing new events, instead of having them as default and needing to remember to remove them for other calls.Related issues
closes #1634