feat: container-info for AWS ECS/Fargate; [5s,1d] guard on central config re-fetch interval#3008
Merged
feat: container-info for AWS ECS/Fargate; [5s,1d] guard on central config re-fetch interval#3008
Conversation
…nfig re-fetch interval Update elastic-apm-http-client to get these changes. This also drops using 'container-info' directly in this repo's tests. Given that the impl in that module and in the http-client might diverge over time, it isn't necessarily valid to use 'container-info' here. Closes: #2914 Closes: #2941
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
astorm
approved these changes
Oct 27, 2022
PeterEinberger
pushed a commit
to fpm-git/apm-agent-nodejs
that referenced
this pull request
Aug 20, 2024
…nfig re-fetch interval (elastic#3008) Update elastic-apm-http-client to get these changes. This also drops using 'container-info' directly in this repo's tests. Given that the impl in that module and in the http-client might diverge over time, it isn't necessarily valid to use 'container-info' here. Closes: elastic#2914 Closes: elastic#2941
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update elastic-apm-http-client to get these changes.
This also drops using 'container-info' directly in this repo's tests.
Given that the impl in that module and in the http-client might
diverge over time, it isn't necessarily valid to use 'container-info'
here.
Closes: #2914
Closes: #2941