Skip to content

refactor: RunContext.exitSpan() -> .leaveSpan()#2703

Merged
trentm merged 1 commit intomainfrom
trentm/refactor-exitSpan-leaveSpan
May 18, 2022
Merged

refactor: RunContext.exitSpan() -> .leaveSpan()#2703
trentm merged 1 commit intomainfrom
trentm/refactor-exitSpan-leaveSpan

Conversation

@trentm
Copy link
Copy Markdown
Member

@trentm trentm commented May 18, 2022

This avoids the name collision with the "exitSpan" option when creating
a span in the public API.

Closes: #2680

@trentm
refactor: RunContext.exitSpan() -> .leaveSpan()
a221780 
This avoids the name collision with the "exitSpan" option when creating
a span in the public API.

Closes: #2680
@trentm trentm requested a review from astorm May 18, 2022 16:26
@trentm trentm self-assigned this May 18, 2022
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label May 18, 2022
@ghost
Copy link
Copy Markdown

ghost commented May 18, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-18T16:26:18.889+0000

  • Duration: 21 min 44 sec

Test stats 🧪

Test Results
Failed 0
Passed 256695
Skipped 0
Total 256695

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run module tests for <modules> : Run TAV tests for one or more modules, where <modules> can be either a comma separated list of modules (e.g. memcached,redis) or the string literal ALL to test all modules

  • run benchmark tests : Run the benchmark test only.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@trentm trentm merged commit 9f380d0 into main May 18, 2022
@trentm trentm deleted the trentm/refactor-exitSpan-leaveSpan branch May 18, 2022 22:23
astorm pushed a commit that referenced this pull request May 19, 2022
@trentm
refactor: RunContext.exitSpan() -> .leaveSpan() (#2703)
d31e33c 
This avoids the name collision with the "exitSpan" option when creating
a span in the public API.

Closes: #2680
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@astorm astorm astorm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@trentm trentm

Labels

agent-nodejs Make available for APM Agents project planning.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

refactor s/exitSpan/leaveSpan/ on RunContext

3 participants

@trentm @astorm @elastic-apm-tech