Skip to content

Neutral naming for apm-agent-nodejs#2535

Merged
v1v merged 1 commit intoelastic:mainfrom
v1v:feature/agent-nodejs-neutral-naming
Jan 20, 2022
Merged

Neutral naming for apm-agent-nodejs#2535
v1v merged 1 commit intoelastic:mainfrom
v1v:feature/agent-nodejs-neutral-naming

Conversation

@v1v
Copy link
Copy Markdown
Member

@v1v v1v commented Jan 18, 2022

What does this pull request do?

Neutral naming

@v1v v1v added the automation label Jan 18, 2022
@v1v v1v requested review from a team January 18, 2022 18:39
@v1v v1v self-assigned this Jan 18, 2022
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Jan 18, 2022
This was referenced Jan 18, 2022
Merged
Merged
@ghost
Copy link
Copy Markdown

ghost commented Jan 18, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-01-18T18:39:52.484+0000

  • Duration: 21 min 20 sec

  • Commit: 8eedc5b

Test stats 🧪

Test Results
Failed 0
Passed 243027
Skipped 0
Total 243027

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run module tests for <modules> : Run TAV tests for one or more modules, where <modules> can be either a comma separated list of modules (e.g. memcached,redis) or the string literal ALL to test all modules

  • run benchmark tests : Run the benchmark test only.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@astorm astorm requested a review from bmorelli25 January 18, 2022 19:34
@astorm
Copy link
Copy Markdown
Contributor

astorm commented Jan 18, 2022

@bmorelli25 quick question -- when making the master to main transition will anything in the docs automated need to be changed/accounted for, or will everything continue to run as smoothly as it usually does?

astorm
astorm reviewed Jan 18, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@astorm astorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I didn't dive too deeply into the Jenkinsfile changes but everything here looks reasonable. @v1v quick question -- once this lands is there anything else that you'all will need to do other than the actual forking of master to main and setting main as the new default?

bmorelli25
bmorelli25 reviewed Jan 18, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmorelli25 quick question -- when making the master to main transition will anything in the docs automated need to be changed/accounted for, or will everything continue to run as smoothly as it usually does?

Yes! Victor has a PR opened here to make sure the docs stay running smoothly: elastic/docs#2353

@v1v v1v merged commit b7cf05a into elastic:main Jan 20, 2022
astorm pushed a commit that referenced this pull request Feb 4, 2022
@v1v
Neutral naming for apm-agent-nodejs (#2535)
363aa6f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmorelli25 bmorelli25 bmorelli25 left review comments

@trentm trentm trentm approved these changes

+1 more reviewer

@astorm astorm astorm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@v1v v1v

Labels

agent-nodejs Make available for APM Agents project planning. automation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@v1v @astorm @trentm @bmorelli25 @elastic-apm-tech