Merged
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
trentm
requested changes
Jul 20, 2021
Co-authored-by: Trent Mick <trent.mick@elastic.co>
trentm
reviewed
Jul 22, 2021
Contributor
Author
|
Updated to match spec changes -- specifically
Marking ready for review -- current failures appear unrelated. |
trentm
previously approved these changes
Aug 25, 2021
trentm
approved these changes
Aug 26, 2021
dgieselaar
pushed a commit
to dgieselaar/apm-agent-nodejs
that referenced
this pull request
Sep 10, 2021
* Implements implementation of Amazon SNS for the v2 APIs elastic#1955 Co-authored-by: Trent Mick <trent.mick@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1955
This PR implements the AWS SNS spec for the AWS v2 SDK. Per the spec, it only instruments the publish API, and takes these proposed changes into account.
Checklist