fix: support all falsy return values from error filters#1389
Merged
Qard merged 1 commit intoelastic:masterfrom Sep 25, 2019
Merged
fix: support all falsy return values from error filters#1389Qard merged 1 commit intoelastic:masterfrom
Qard merged 1 commit intoelastic:masterfrom
Conversation
Previously, an error would be thrown if the user returned either `null` or `undefined` from a filter if the event being filtered was an error. Fixes elastic#1385
Qard
approved these changes
Sep 25, 2019
watson
added a commit
to watson/apm-agent-nodejs
that referenced
this pull request
Sep 25, 2019
Previously, an error would be thrown if the user returned either `null` or `undefined` from a filter if the event being filtered was an error. Fixes elastic#1385
watson
added a commit
that referenced
this pull request
Sep 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, an error would be thrown if the user returned either
nullorundefinedfrom a filter if the event being filtered was an error.Fixes #1385