Skip to content

Change 'cloud.project.id' for GCP metadata to be the 'project-id'#3316

Merged
JonasKunz merged 2 commits intoelastic:mainfrom
trentm:trentm/gcp-metadata-cloud-project-id
Sep 13, 2023
Merged

Change 'cloud.project.id' for GCP metadata to be the 'project-id'#3316
JonasKunz merged 2 commits intoelastic:mainfrom
trentm:trentm/gcp-metadata-cloud-project-id

Conversation

@trentm
Copy link
Copy Markdown
Member

@trentm trentm commented Sep 8, 2023

Closes: #3311

@trentm trentm marked this pull request as ready for review September 8, 2023 23:51
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 8, 2023

/test

JonasKunz
JonasKunz previously approved these changes Sep 13, 2023
Copy link
Copy Markdown
Contributor

@JonasKunz JonasKunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this!

@JonasKunz JonasKunz enabled auto-merge (squash) September 13, 2023 07:56
@JonasKunz JonasKunz disabled auto-merge September 13, 2023 09:31
@JonasKunz JonasKunz merged commit 481ee25 into elastic:main Sep 13, 2023
@trentm trentm deleted the trentm/gcp-metadata-cloud-project-id branch September 13, 2023 16:36
schikin pushed a commit to schikin/apm-agent-java that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[META 826] changes to metadata.cloud.project.* fields collected for GCP

4 participants