Skip to content

Make sanitize_field_names centrally configurable#856

Merged
axw merged 2 commits intoelastic:masterfrom
axw:sanitizedfieldnames-centralconfig
Dec 8, 2020
Merged

Make sanitize_field_names centrally configurable#856
axw merged 2 commits intoelastic:masterfrom
axw:sanitizedfieldnames-centralconfig

Conversation

@axw
Copy link
Copy Markdown
Member

@axw axw commented Dec 2, 2020

Closes #821

@axw axw requested a review from a team December 2, 2020 05:47
@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 2, 2020

Codecov Report

Merging #856 (f4a273c) into master (d72ef83) will decrease coverage by 0.11%.
The diff coverage is 86.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #856      +/-   ##
==========================================
- Coverage   83.83%   83.72%   -0.12%     
==========================================
  Files         141      141              
  Lines        7849     7863      +14     
==========================================
+ Hits         6580     6583       +3     
- Misses        863      871       +8     
- Partials      406      409       +3
Impacted Files Coverage Δ
apmtest/configwatcher.go 100.00% <ø> (ø)
apmtest/discard.go 80.00% <ø> (ø)
apmtest/env.go 100.00% <ø> (ø)
apmtest/httpsuite.go 100.00% <ø> (ø)
apmtest/recorder.go 77.77% <ø> (ø)
apmtest/recordlogger.go 87.50% <ø> (ø)
apmtest/testlogger.go 66.66% <ø> (ø)
apmtest/withtransaction.go 100.00% <ø> (ø)
breakdown.go 95.38% <ø> (ø)
builtin_metrics.go 81.81% <ø> (ø)
... and 104 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b228473...f4a273c. Read the comment docs.

@ghost
Copy link
Copy Markdown

ghost commented Dec 2, 2020 •
edited by ghost
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #856 updated

  • Start Time: 2020-12-08T09:14:23.603+0000

  • Duration: 26 min 1 sec

Test stats 🧪

Test Results
Failed 0
Passed 7648
Skipped 185
Total 7833

@axw axw merged commit 251ea72 into elastic:master Dec 8, 2020
@axw axw deleted the sanitizedfieldnames-centralconfig branch December 8, 2020 09:41
@AlexanderWert
Copy link
Copy Markdown
Member

AlexanderWert commented Dec 8, 2020

@axw Thanks for finishing this! Could you also please add the Go agent in Kibana for this central config option: https://github.com/elastic/kibana/blob/caa14d44efedc801fd1f779e15442ca9d5f2fab7/x-pack/plugins/apm/common/agent_configuration/setting_definitions/general_settings.ts#L238

@axw axw mentioned this pull request Dec 9, 2020
Merged
2 tasks
@axw
Copy link
Copy Markdown
Member Author

axw commented Dec 9, 2020

Thanks for the reminder @AlexanderWert, I've opened elastic/kibana#85373

axw added a commit to elastic/kibana that referenced this pull request Dec 10, 2020
@axw
[APM] enable 'sanitize_field_names' for Go (#85373)
d8a9407 
elastic/apm-agent-go#856 added
central config support for 'sanitize_field_names' to the
Go agent, so we can now enable it in the UI too.
axw added a commit to elastic/kibana that referenced this pull request Dec 10, 2020
@axw
[APM] enable 'sanitize_field_names' for Go (#85373) (#85499)
f94e564 
elastic/apm-agent-go#856 added
central config support for 'sanitize_field_names' to the
Go agent, so we can now enable it in the UI too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jalvz jalvz jalvz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

agent-go

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[META 319] Make SANITIZE_FIELD_NAMES centrally configurable

4 participants

@axw @codecov-io @AlexanderWert @jalvz