Skip to content

Removing inactive_file.bytes metric#339

Merged
eyalkoren merged 1 commit intomasterfrom
remove-inactive-bytes
Sep 16, 2020
Merged

Removing inactive_file.bytes metric#339
eyalkoren merged 1 commit intomasterfrom
remove-inactive-bytes

Conversation

@eyalkoren
Copy link
Copy Markdown
Contributor

@eyalkoren eyalkoren commented Sep 16, 2020

Removing the requirement to report system.process.cgroup.memory.stats.inactive_file.bytes - subtracting that from usage is only required if calculating working set, but we are only interested in usage.

@eyalkoren eyalkoren requested a review from axw September 16, 2020 10:03
@eyalkoren eyalkoren requested review from a team as code owners September 16, 2020 10:03
@ghost
Copy link
Copy Markdown

ghost commented Sep 16, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #339 opened]

  • Start Time: 2020-09-16T10:03:32.022+0000

  • Duration: 3 min 35 sec

@eyalkoren eyalkoren removed request for a team September 16, 2020 10:12
Copy link
Copy Markdown
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@eyalkoren eyalkoren removed request for a team September 16, 2020 12:25
@eyalkoren
Copy link
Copy Markdown
Contributor Author

pining @elastic/apm-agent-net and @elastic/apm-agent-python where I think this is already underway.

@eyalkoren eyalkoren merged commit bd925e2 into master Sep 16, 2020
@eyalkoren eyalkoren deleted the remove-inactive-bytes branch September 16, 2020 12:26
@eyalkoren eyalkoren changed the title Update metrics.md Removing system.process.cgroup.memory.stats.inactive_file.bytes metric Sep 16, 2020
@eyalkoren eyalkoren changed the title Removing system.process.cgroup.memory.stats.inactive_file.bytes metric Removing inactive_file.bytes metric Sep 16, 2020
beniwohli pushed a commit to felixbarny/apm that referenced this pull request Sep 21, 2020
stevejgordon added a commit to elastic/apm-agent-dotnet that referenced this pull request Nov 9, 2023
- Implement changes to unlimited memory metric.
- Remove inactive_file.bytes per elastic/apm#339
- Refactor code
- Optimise code to avoid allocations.
stevejgordon added a commit to elastic/apm-agent-dotnet that referenced this pull request Nov 9, 2023
- Implement changes to unlimited memory metric.
- Remove inactive_file.bytes per elastic/apm#339
- Refactor code
- Optimise code to avoid allocations.
stevejgordon added a commit to elastic/apm-agent-dotnet that referenced this pull request Nov 15, 2023
- Implement changes to unlimited memory metric.
- Remove inactive_file.bytes per elastic/apm#339
- Refactor code
- Optimise code to avoid allocations.
stevejgordon added a commit to elastic/apm-agent-dotnet that referenced this pull request Nov 15, 2023
* Update metrics providers

- Implement changes to unlimited memory metric.
- Remove inactive_file.bytes per elastic/apm#339
- Refactor code
- Optimise code to avoid allocations.

* Update and add tests

* Update benchmarks and add profiling project

* Update editorconfig to avoid range errors

* Cleanup white space in build.fs

* Linux bug fixes

* Fix formatting

* Remove commented code

* Add code comment

* Fixes after rebase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants