Skip to content

Include "number of rows affected" in the data captured for SQL commands #112

@SergeyKleyman

Description

@SergeyKleyman

Description of the issue

Some SQL commands return the number of rows affected by the command. For example
.NET's SqlCommand.ExecuteNonQuery.
It might be useful for users to get this number as part of the data captured for the relevant SQL commands. For example requested at https://discuss.elastic.co/t/include-record-count-on-read-or-write/189110

Proposed solution

We should add a property (for example number_of_rows_affected) of type number to context.db object in intake API for agents to send captured number.

If you have concerns about the proposed solution, let's discuss.

What we are voting on

@elastic/apm-agent-devs

  • If you agree that we should add this feature, please tick "Yes", and link to the child issue for your agent
  • If you think that we shouldn't add this feature, please tick "No". A comment with the explanation as to why you think so would be greatly appreciated.
  • If you don't care whether we add this feature or not, please tick "Indifferent"
  • If this feature is not applicable to your agent (for example your agent doesn't capture SQL commands that have "number of rows affected" as their result), please tick "N/A"
Agent Yes No Indifferent N/A Link to agent issue
.NET
elastic/apm-agent-dotnet#360
Go
elastic/apm-agent-go#578
Java
elastic/apm-agent-java/issues/707
Node.js
elastic/apm-agent-nodejs#1709
Python
elastic/apm-agent-python#613
Ruby
elastic/apm-agent-ruby#574

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions