Allow efa-device-plugin container to run as root#6435
Closed
DanielJuravski wants to merge 1 commit intoeksctl-io:mainfrom
Closed
Allow efa-device-plugin container to run as root#6435DanielJuravski wants to merge 1 commit intoeksctl-io:mainfrom
DanielJuravski wants to merge 1 commit intoeksctl-io:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Hello DanielJuravski 👋 Thank you for opening a Pull Request in eksctl project. The team will review the Pull Request and aim to respond within 1-10 business days. Meanwhile, please read about the Contribution and Code of Conduct guidelines here. You can find out more information about eksctl on our website
Contributor
|
dupe of #6302 |
Author
|
@Himangini #6302 was closed - the bug still exists, this tiny commit fixes this bug, is something missing for a review? |
|
hi, I have published helm chart for EFA device plugin (https://github.com/aws-samples/efa-device-plugin-helm) if it helps, I'm also working on pushing this to our public Helm registry. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
efa-device-plugin container need to run as root.
This Commit is a follow up commit to #6065,
It closes aws-samples/aws-efa-eks#8.
Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯