fix runAsNonRoot (true) efa device plugin bug#6302
Merged
cPu1 merged 1 commit intoeksctl-io:mainfrom Jul 4, 2024
Merged
Conversation
7 tasks
Contributor
Author
|
Why was this closed? The bug is still there. |
|
This helm chart resolved the issue https://github.com/aws-samples/efa-device-plugin-helm |
cPu1
approved these changes
Jun 21, 2024
Contributor
cPu1
left a comment
There was a problem hiding this comment.
@vsoch, really apologize for the delay. This got slipped through the cracks.
Given that the official Helm chart also defaults to runAsNonRoot: false, we should do that too.
49bf3eb to
53425e5
Compare
Contributor
|
The unit tests are failing due to #7845. We're working on a fix. |
Contributor
|
@vsoch can you rebase with |
The plugins were globally changed to have runAsNonRoot set to true. This breaks the efa plugin, which currently requires it. This PR was tested and confirmed to fix the bug in several cases. Signed-off-by: vsoch <vsoch@users.noreply.github.com>
53425e5 to
d83fd8a
Compare
Contributor
Author
|
@cPu1 all set. |
Contributor
Great. Thanks! Appreciate your patience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugins were globally changed to have runAsNonRoot set to true. This breaks the efa plugin, which
currently requires it. This PR was tested and confirmed to fix the bug in several cases. This will close #6222, and the other suggestions tried are also mentioned there.
Thanks for working on eksctl, we are using it a lot!
Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯