Remove runAsNonRoot config for nvidia-device-plugin demonset#6026
Closed
wjxiz1992 wants to merge 1 commit intoeksctl-io:mainfrom
Closed
Remove runAsNonRoot config for nvidia-device-plugin demonset#6026wjxiz1992 wants to merge 1 commit intoeksctl-io:mainfrom
wjxiz1992 wants to merge 1 commit intoeksctl-io:mainfrom
Conversation
Signed-off-by: Allen Xu <allxu@nvidia.com>
Contributor
There was a problem hiding this comment.
Hello wjxiz1992 👋 Thank you for opening a Pull Request in eksctl project. The team will review the Pull Request and aim to respond within 1-10 business days. Meanwhile, please read about the Contribution and Code of Conduct guidelines here. You can find out more information about eksctl on our website
Author
|
As a newbee to eksctl, I don't know GO language ,either how to write tests for this config change(I imagine there's a minikube test framework where tests can run on, you won't really create an EKS cluster for test, right?). Feel free to close this draft PR and post your real professional fix. |
7 tasks
Contributor
|
@wjxiz1992 thanks for signalling this one and opening a PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Allen Xu allxu@nvidia.com
This PR removes the runAsNonRoot config that was introduced in #5970
To close: #6025
Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯