Skip to content

Update Kubernetes configuration#5970

Merged
Himangini merged 2 commits intoeksctl-io:mainfrom
Himangini:update-k8s-configurations
Nov 25, 2022
Merged

Update Kubernetes configuration#5970
Himangini merged 2 commits intoeksctl-io:mainfrom
Himangini:update-k8s-configurations

Conversation

@Himangini
Copy link
Copy Markdown
Contributor

@Himangini Himangini commented Nov 22, 2022 •
edited
Loading

Description

Updated k8s config and added minversion in getIssueCAThumbrint

Closes : https://github.com/weaveworks/eksctl-private/issues/625
https://github.com/weaveworks/eksctl-private/issues/615

integration tests passing : https://github.com/weaveworks/eksctl-ci/actions/runs/3542241045

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@Himangini Himangini added technical debt area/tech-debt Leftover improvements in code, testing and building labels Nov 22, 2022
@Himangini Himangini requested review from TiberiuGC and cPu1 November 23, 2022 11:50
TiberiuGC
TiberiuGC reviewed Nov 23, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@TiberiuGC TiberiuGC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one more occurrence of privileged: true here. Should this one stay as is?

@Himangini
Copy link
Copy Markdown
Contributor Author

Himangini commented Nov 24, 2022

There's one more occurrence of privileged: true here. Should this one stay as is?

Yeah, this file is auto-generated so making changes here won't stick i'm afraid.

@Himangini Himangini force-pushed the update-k8s-configurations branch from 86c9751 to 34c5996 Compare November 25, 2022 09:42
@Himangini Himangini enabled auto-merge November 25, 2022 09:46
@Himangini Himangini merged commit 48862e4 into eksctl-io:main Nov 25, 2022
This was referenced Dec 7, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@cPu1 cPu1 cPu1 approved these changes

@TiberiuGC TiberiuGC TiberiuGC approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/tech-debt Leftover improvements in code, testing and building

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Himangini @cPu1 @TiberiuGC