Remove add_import script as support for package imports has been added upstream.#5056
Merged
Skarlso merged 8 commits intoeksctl-io:mainfrom Apr 6, 2022
Skarlso:remove_import_script
Merged
Remove add_import script as support for package imports has been added upstream.#5056Skarlso merged 8 commits intoeksctl-io:mainfrom Skarlso:remove_import_script
Skarlso merged 8 commits intoeksctl-io:mainfrom
Skarlso:remove_import_script
Conversation
aclevername
approved these changes
Apr 4, 2022
Contributor
Author
|
OH I have to update the build image eh? |
Contributor
Author
|
Ok, pushed the images. |
Skarlso
commented
Apr 4, 2022
cPu1
approved these changes
Apr 6, 2022
nikimanoledaki
approved these changes
Apr 6, 2022
SlevinWasAlreadyTaken
pushed a commit
to SlevinWasAlreadyTaken/eksctl
that referenced
this pull request
Apr 11, 2022
…d upstream. (eksctl-io#5056) * Remove add_import script as support for package imports has been added upstream. * Update build image manifest, tag file and workflows * Updated the build image manifest... * Update build image manifest, tag file and workflows * Updated mod file with proper version * Update build image manifest, tag file and workflows
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #4994
Support for adding a dot import has been added in ifacemaker. We pin to that specific version in the requirements.txt.
Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯