restserver docker image: set jdk17 for all platforms#1713
Conversation
|
btw, I only tested for |
|
I can quickly test amd64 tomorrow, thank you!! Joex is a bit more involved because it requires more tools to be available. The biggest hurdle is that wkhtmltopdf is not available anymore on alpine > 3.14 (afaik). We could use the drop-in replacement weasyprint, though. I did some tests a while ago and found wkhtmltopdf still a bit better - but don't see other options. Maybe only basing on a different distribution, like ubuntu (which increases image size). |
|
Oh and docspell still uses scala 2.13 :-) but I guess jdk17 is fine. We could also just change it for the arm images, if we want to be less "drastic" :) but I don't care much. |
|
Yay, would be great if you could test amd64. Okay I see regarding the wkhtmltopdf and joex. Maybe we could manually install it from binary or so? If you want I can also do some reasearch there. I prefer alpine or slim images, bigger images like ubuntu etc. have many drawbacks like bigger attack surface, longer loading times, more space usage etc. I would vote for to keeping your current approach with alpine. Uff, messed up the numbers, I mean
So 2.13.8 should be fine as well. But it's your project so totally up to you, I'm happy either way. |
|
I'm fine with updating it on all architectures. 👍🏼 |
|
Sadly it looks like there is no openjdk17 package for armv7 (that I did not test :)) Only openjdk8 is available. Maybe we need to drop support for armv7 or consider different base distribution. |
|
Just saw the error, argh... 😢 Haven't tested Does docker hub tells you if there is someone pulling |
|
Docker hub doesn't tell me how many/often it is downloaded, only the latest download was a month ago. There are some people probably using it, but not many I would assume. We could also use a different base distribution for arm only - but all this docker maintenance goes pretty wild then… :) I think I just drop it, if people need it they can build images themselves. Thanks for your help offering! That is much appreciated! I'm still thinking about what way to go :-) |
|
Yes, different base distribution for armv7 only was my idea / how I understood you. I think the maintenance is not that bad. Of course the initial effort to evaluate a compatible distribution and writing the Dockerfile but from there on - if it is possible to choose a tag that pins down the Major-Version of the Image OS instead of the Minor-Version - the maintenance should be pretty low. And the people that run that special image could also put in some effort, like I did 😄 Speaking of it, one way to go could be to drop support for now and plan to create an image description later. If someone wants to have it faster he/she could put in the effort and come up with one. |
|
ah just read that Edit: But then again Debian has its |
|
Yes you understood correctly :-) I was also thinking loud a little. The docker images are a bit of work to me I have to admit. I'm not a docker expert (or Linux Distro…). Every now and then a package breaks or is gone - I think dropping armv7 is fine for now. It reduces complexity a lot (to me at least). I also tried once the debian-slim images, they are not bad. But after installing required packages it gets much larger than the alpine one. I suppose it has more dependent packages installed (it was worse for joex than restserver iirc). Probably one can put in more effort and bring it down - but I wouldn't bother - it's precious free time wasted for a few megabytes 😄 |
See PR #1713, if support is wanted, please open an issue or better a PR ;-).
This is an attempt to fix #1712. First tests seem to be ok, no crashes anymore. However I will keep using the image for the next few hours, upload some new data and see whether I encounter any issues. Will report back. In the meantime: I made some changes to the image:
curlfor downloading the app.zipbecause I had troubles building the image,wgetfailed during build process. I guess that it doesn't follow redirects because I first had the same issue withcurlbut with the-Lflag it worked3tag so that we always get the newest minor version, what do you think?If you like I can also adjust the
joeximage description with the same changes.... and last but not least, thank you for that awesome webapp 🥳