Allow to pass domain as an argument for createEvent and similar methods
#763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
createEvent and similar methods
AlexandrHoroshih
requested changes
Aug 18, 2022
AlexandrHoroshih
approved these changes
Aug 19, 2022
| }).toThrowErrorMatchingInlineSnapshot( | ||
| `"Domain cannot be created with two domains as parent. Please, remove {domain} argument."`, | ||
| ) | ||
| // @ts-expect-error There is no types for case, just runtime check |
Member
There was a problem hiding this comment.
Probably the other way around 🤔
there is no runtime check for the case, only typecheck
zerobias
approved these changes
Aug 20, 2022
Member
zerobias
left a comment
There was a problem hiding this comment.
Cool, thanks 👍👍 This will go to next minor release as this is not a breaking change and there is a need to publish some features earlier
iposokhin
pushed a commit
to iposokhin/effector-forms
that referenced
this pull request
Dec 10, 2023
Since effector v22.4.0 we can pass a domain as an argument to units factories. This allows us to get rid of the createFormUnits factory and make units creation easier. See more details effector/effector#763
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #590
Conventions